Repository navigation
[web] Disable background networking and GCM in all Chrome launchers - #190841
Conversation
There was a problem hiding this comment.
Code Review
This pull request standardizes Chrome launcher arguments across various tools and packages (including devicelab, engine web_ui, and flutter_tools) by disabling background networking, sync, client-side phishing detection, notifications, and GCM features. The corresponding tests have been updated to reflect these changes. Feedback suggests also adding '--disable-background-timer-throttling' and '--disable-renderer-backgrounding' to the engine's Chrome launcher to ensure consistency and prevent performance throttling during test execution.
79bbd2a to
c5ebab9
Compare
# Conflicts: # packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart
6ea22b6 to
3593644
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces flags to disable GCM, MCS, and other background features in Chrome across multiple test frameworks and launchers. The feedback recommends extracting the kGcmDisabledFlags constant into a separate, lightweight constants file to prevent importing heavy transitive dependencies into WebDriverService, which currently necessitates adding verbose mock overrides in its unit tests.
…rome.dart dependencies
|
autosubmit label was removed for flutter/flutter/190841, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Description
Passes
--disable-background-networking,--disable-sync,--disable-client-side-phishing-detection,--disable-notifications, and--disable-features=GCMconsistently across all Chrome launchers:packages/flutter_tools/lib/src/web/chrome.dartpackages/flutter_tools/lib/src/drive/web_driver_service.dartdev/devicelab/lib/framework/browser.dartengine/src/flutter/lib/web_ui/dev/chrome.dartThis prevents Chrome background networking services from initiating registration calls to deprecated GCM endpoints (
google_apis/gcm/engine/registration_request.cc) during CI test runs, eliminating stderr log noise:Tests
chrome_test.dartandweb_driver_service_test.dart.