[tool] Migrate BuildApkCommand and Android build toolchain to modular dependency injection - #190776

Code Review

This pull request refactors BuildCommand and its subcommands (BuildAarCommand, BuildApkCommand, and BuildAppBundleCommand) to explicitly inject dependencies like AndroidContext and ToolContext instead of relying on global variables, and updates associated tests to run without context. The review feedback highlights a few areas for improvement: avoiding the use of OutputPreferences.test() as a fallback in production code, caching the project getter in BuildAarCommand and BuildAppBundleCommand to prevent redundant file system I/O and object creation, and ensuring that casting terminal to AnsiTerminal does not discard custom mock implementations in tests.

Code Review

This pull request refactors BuildCommand and its subcommands (BuildAarCommand, BuildApkCommand, and BuildAppBundleCommand) to support dependency injection of ToolContext, AndroidContext, and AndroidBuilder instead of relying on global variables, enabling hermetic testing without context overrides. A critical bug was identified in BuildCommand where omitting the androidBuilder argument during instantiation in production causes it to default to null, resulting in Android builds silently doing nothing. The feedback suggests falling back to context.get() when the injected builder is null.

Code Review

This pull request refactors the Android build commands (BuildAarCommand, BuildApkCommand, and BuildAppBundleCommand) to accept their dependencies directly through their constructors instead of relying on global context, enabling them to be tested using testWithoutContext. Feedback suggests caching the _featureFlags getter in FlutterCommand to prevent redundant object allocations and improve performance.

Code Review

This pull request refactors the build command infrastructure in the Flutter tools by introducing ToolContext and AndroidContext to centralize dependencies. It updates BuildCommand and its subcommands (BuildAarCommand, BuildApkCommand, BuildAppBundleCommand) to use these contexts, reducing redundant parameter passing. Additionally, it cleans up test code by introducing fake contexts and updates the exitWithNoSdkMessage utility to accept optional dependencies. The review feedback suggests further simplifying the command constructors and getters by leveraging the androidContext property to access androidSdk and avoiding unnecessary terminal downcasts.

Code Review

This pull request refactors the Android build tooling, specifically AndroidGradleBuilder and BuildApkCommand, to accept context and builder dependencies via their constructors instead of relying on global variables. This change improves testability, and corresponding unit tests have been added or updated. Feedback on the changes notes a regression in gradle_utils.dart where the error parameter was omitted from the Event.flutterBuildInfo telemetry call, which should be restored.

reapproving after rebase/merge.