Repository navigation
Adds Impeller availability to the impeller README.md - #190671
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Impeller README documentation by adding an availability matrix across various platforms and releases, and updating the macOS, Linux, and Windows sections to reflect that Impeller is now enabled by default, including instructions on how to disable it. The review feedback points out a copy-paste artifact in the Windows code block language specifier that should be cleaned up.
| | Releases | iOS | Android | Embedder API (Metal) | Embedder API (Vulkan) | Embedder API (OpenGL) | macOS | Windows | Linux | Web | | ||
| | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | ||
| | **main** | ⭐ | ✅ | 🧪 | 🚧 | 🚧 | ✅ | ✅ | ✅ | 🚫 | | ||
| | **3.47** | ⭐ | ✅ | 🧪 | 🚧 | 🚧 | ✅ | ✅ | ✅ | 🚫 | |
There was a problem hiding this comment.
Should Embedder API (OpenGL) be 🧪?
There was a problem hiding this comment.
That's not what it is in the doc. I have no information to suggest it's wrong. You guys are looking at the embedder stuff, probably better if you initiate the change in a followup.
There was a problem hiding this comment.
Given Windows and Linux are using Impeller OpenGL through the embedder API, I'd hope it's not experimental any more :)
There was a problem hiding this comment.
There are no more considerations for generic embedder usage?
There was a problem hiding this comment.
Potential considerations:
- We should add more docs to the OpenGL APIs to explain Impeller's requirements (eg, you need depth and stencil buffer attachments)
- Flutter Windows and Flutter Linux don't exercise all the OpenGL APIs available on the embedder API, so it's possible there are bugs, or feature gaps. We might want to do a pass on the engine's tests.
Regardless, I'd say we've entered the preview phase by shipping stuff to production.
|
autosubmit label was removed for flutter/flutter/190671, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
source: https://docs.google.com/spreadsheets/d/1AebMvprRkxP-D6ndx920lbvDBbhg-sNNRJ64XY2P2t0/edit?gid=0#gid=0
We are going to deprecate that sheets doc and rely on this markdown section.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.