Repository navigation
[web] Provide Content-Length header for main.dart.wasm in flutter test - #190584
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the WASM request handler in flutter_web_platform.dart to include the Content-Length header. The review feedback suggests verifying the existence of the WASM file before calling lengthSync() to prevent potential runtime exceptions, and recommends using string literals instead of HttpHeaders constants to maintain consistency with the surrounding code.
|
I think we also might need to do this for the web benchmark harness as well. |
According to Gemini, the web benchmarks harness doesn't need this because it uses The test server in However, the cascade = cascade.add(createStaticHandler(
path.join(benchmarkAppDirectory.path, 'build', 'web'),
defaultDocument: 'index.html',
));Under the hood, |
This adds the
Content-Lengthheader formain.dart.wasmwhen it's served in theshelftest server. This complements PR #190155 which fixed this forcanvaskit.wasm. By providing theContent-Lengthheader,shelfavoids falling back toTransfer-Encoding: chunked, which prevents a bug in Chrome 145's WebAssembly compilation from hanging Skwasm tests.Fixes #189275
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.