Repository navigation
[Flutter GPU] Ignore redundant render pass state assignments - #190379
Merged
auto-submit[bot] merged 1 commit intoAug 5, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
bdero
marked this pull request as ready for review
August 1, 2026 04:38
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a pipeline caching mechanism in RenderPass by caching the resolved pipeline and invalidating it when relevant state changes occur. It also adds corresponding unit tests to verify pipeline reuse and invalidation. The feedback recommends adding /// documentation comments to the newly introduced public and private methods to adhere to the repository's style guide.
wolfenrain
previously approved these changes
Aug 1, 2026
bdero
force-pushed
the
bdero/flutter-gpu-resolved-pipeline-cache
branch
from
August 2, 2026 04:33
7619fac to
5336200
Compare
wolfenrain
approved these changes
Aug 5, 2026
This was referenced Aug 6, 2026
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #189899.
RenderPassmemoizes its built pipeline behind a dirty flag, but the fixed-function setters all assign throughGetPipelineDescriptor, which dirties unconditionally. Callers re-send the same cull mode, winding order, primitive type, and polygon mode ahead of most draws, and rebind the same pipeline, so the memo was being invalidated on nearly every draw. These setters now compare before assigning and leave the state clean when nothing changed.