Sitelet https://github.com/flutter/flutter/pull/190248
Skip to content

Migrate examples/splash to package:material_ui - #190248

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
elliette:issue-190093-splash
Aug 7, 2026
Merged

Migrate examples/splash to package:material_ui#190248
auto-submit[bot] merged 3 commits into
flutter:masterfrom
elliette:issue-190093-splash

Conversation

@elliette

@elliette elliette commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Work towards #190093

Migrates examples/splash to material_ui

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Test exemption: Migration only.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@github-actions github-actions Bot added the d: examples Sample code and demos label Jul 29, 2026
@elliette elliette added the CICD Run CI/CD label Jul 29, 2026
@elliette elliette changed the title Issue 190093 splash Migrate example/splash to package:material_ui Jul 29, 2026
@elliette elliette changed the title Migrate example/splash to package:material_ui Migrate examples/splash to package:material_ui Jul 29, 2026
justinmc
justinmc previously approved these changes Jul 29, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elliette
elliette marked this pull request as ready for review July 29, 2026 23:05
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 29, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the official package:flutter/material.dart import with a third-party package:material_ui/material_ui.dart dependency in the splash example and its tests. Feedback from the reviewer highlights that Flutter examples must rely solely on the official Flutter SDK to prevent supply chain security risks, and recommends reverting these changes to use the official package.

Comment thread examples/splash/lib/main.dart
Comment thread examples/splash/pubspec.yaml
Comment thread examples/splash/test/splash_test.dart
@elliette elliette mentioned this pull request Jul 30, 2026
Merged
@elliette
elliette force-pushed the issue-190093-splash branch from d5dc5ed to 008eb3b Compare July 30, 2026 17:11
@elliette
elliette requested a review from justinmc July 30, 2026 17:12
justinmc
justinmc previously approved these changes Jul 30, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should hold off until this comment is addressed #190237 (comment).

@justinmc

justinmc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Now that #190237 is merged I think you just need to update this branch and it should pass CI.

@elliette
elliette force-pushed the issue-190093-splash branch from 008eb3b to a774577 Compare July 30, 2026 22:00
@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2026
@auto-submit

auto-submit Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190248, because - The status or check suite Tree_analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@justinmc

justinmc commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

There's a failure saying that you need to run flutter update-packages --force-upgrade --update-hashes.

@elliette
elliette force-pushed the issue-190093-splash branch from a774577 to dbca5e3 Compare July 31, 2026 19:43
@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026
@auto-submit

auto-submit Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190248, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2026
@justinmc
justinmc self-requested a review August 5, 2026 17:42
justinmc
justinmc previously approved these changes Aug 5, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 6, 2026
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026
@elliette
elliette force-pushed the issue-190093-splash branch from fbdc436 to ebf22e0 Compare August 6, 2026 16:48
@elliette
elliette requested a review from justinmc August 6, 2026 16:48
justinmc
justinmc approved these changes Aug 6, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re LGTM 👍

@elliette elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 6, 2026
Merged via the queue into flutter:master with commit b785398 Aug 7, 2026
22 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2026
This was referenced Aug 7, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@GhagSagar23 GhagSagar23 mentioned this pull request Aug 19, 2026
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elliette @justinmc @VivaLaRoy