Sitelet https://github.com/flutter/flutter/pull/190158
Skip to content

Manual roll of Dart from 28e63ac22d8d to 49c637261348 - #190158

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
jason-simmons:roll_dart_072826
Jul 29, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
jason-simmons:roll_dart_072826

Conversation

@jason-simmons

@jason-simmons jason-simmons commented Jul 28, 2026 •

Copy link
Copy Markdown
Member

This contains a change to the Dart analyzer that affects how exclude paths are used in analysis_options.yaml files.

(see https://dart.googlesource.com/sdk.git/+/7c44c487f41e3a19bafa1fb7c309d6035d5e036b)

fixes #190169

This contains a change to the Dart analyzer that affects how exclude paths are used in analysis_options.yaml files.

(see https://dart.googlesource.com/sdk.git/+/7c44c487f41e3a19bafa1fb7c309d6035d5e036b)
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the "engine/**" pattern from the excluded analysis paths in analysis_options.yaml. There are no review comments, and I have no feedback to provide.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jul 28, 2026
@jason-simmons
jason-simmons requested a review from gaaclarke July 28, 2026 22:53
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 29, 2026
Merged via the queue into flutter:master with commit a92b952 Jul 29, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 6, 2026
…tors (#12384)

Removes invalid `@JS()` annotations from extension type constructors in `packages/camera/camera_web`.

Fixes flutter/flutter#190355

### Description
In newer Dart SDKs (following Dart SDK commit dart-lang/sdk@cecd7ec rolled into Flutter in PR flutter/flutter#190158), placing `@JS()` annotations on extension type constructors has no effect and is now flagged as an error (`invalid_js_annotation`).

Removing these annotations resolves the error without altering runtime behavior.
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 8, 2026
…12393)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@2a230d1...2757a77

2026-07-29 engine-flutter-autoroll@skia.org Roll Skia from 3ae9e364d30b to 0f35bba4945c (2 revisions) (flutter/flutter#190215)
2026-07-29 kustermann@google.com [web] Fix deferred loading with wasm (flutter/flutter#190140)
2026-07-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 1bbaacba6a5a to 43f7de5f4977 (1 revision) (flutter/flutter#190211)
2026-07-29 engine-flutter-autoroll@skia.org Roll Skia from 119cae396625 to 3ae9e364d30b (6 revisions) (flutter/flutter#190208)
2026-07-29 matej.knopp@gmail.com [Win32] Ignore mouse move events without capture when dragging (flutter/flutter#190029)
2026-07-29 engine-flutter-autoroll@skia.org Roll Dart SDK from 49c637261348 to 1bbaacba6a5a (7 revisions) (flutter/flutter#190196)
2026-07-29 engine-flutter-autoroll@skia.org Roll Skia from 30ad01017a46 to 119cae396625 (2 revisions) (flutter/flutter#190183)
2026-07-29 46920873+gabrimatic@users.noreply.github.com Fix NestedScrollView example crash when switching tabs on desktop (flutter/flutter#186993)
2026-07-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OZkZC_2CZ_G5rbMIS... to J8rVTlBnjnUpuHYk3... (flutter/flutter#190174)
2026-07-29 git@schultek.dev Update widget location tracking to use the new generalized api (flutter/flutter#189725)
2026-07-29 bernaferrari2@gmail.com Avoid unnecessary work in `BoxDecoration` and `RenderPhysicalModel` (flutter/flutter#187891)
2026-07-29 me@davidmiguel.com Fix web context-menu client lifecycle in SelectableRegion (flutter/flutter#189587)
2026-07-29 engine-flutter-autoroll@skia.org Roll Skia from 70733f74d415 to 30ad01017a46 (2 revisions) (flutter/flutter#190173)
2026-07-29 jason-simmons@users.noreply.github.com Manual roll of Dart from 28e63ac22d8d to 49c637261348 (flutter/flutter#190158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dart roller blocked on changes to analyzer logic

2 participants