Sitelet https://github.com/flutter/flutter/pull/190062
Skip to content

Add dot shorthands support for focus order - #190062

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
navaronbracke:focus_traversal_order_dot_shorthand
Aug 5, 2026
Merged

Add dot shorthands support for focus order#190062
auto-submit[bot] merged 3 commits into
flutter:masterfrom
navaronbracke:focus_traversal_order_dot_shorthand

Conversation

@navaronbracke

@navaronbracke navaronbracke commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR adds dot shorthand support for lexical / numeric focus traversal order

Fixes #189991

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 27, 2026
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels Jul 27, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces FocusOrder.lexical and FocusOrder.numeric factory constructors to the FocusOrder class, updating various usages and tests across the codebase to use these new constructors. Feedback suggests refining the documentation of these factory constructors to explicitly reference their respective concrete subclasses, LexicalFocusOrder and NumericFocusOrder, for better clarity.

Comment thread packages/flutter/lib/src/widgets/focus_traversal.dart Outdated
@navaronbracke
navaronbracke force-pushed the focus_traversal_order_dot_shorthand branch from 8505211 to af92ff6 Compare July 27, 2026 18:35
FMorschel
FMorschel reviewed Jul 28, 2026
View reviewed changes
Comment thread examples/api/lib/widgets/focus_traversal/focus_traversal_group.0.dart Outdated
@justinmc
justinmc requested a review from loic-sharma July 28, 2026 21:57
@navaronbracke
navaronbracke requested a review from FMorschel July 29, 2026 06:35
@navaronbracke
navaronbracke force-pushed the focus_traversal_order_dot_shorthand branch from 658c9ab to 5fdeddd Compare July 30, 2026 06:12
@FMorschel

FMorschel commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

LGTM, @navaronbracke! I just can't approve this; I don't have the repo rights.

@navaronbracke

navaronbracke commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

No problem, let's wait for a Googler to review, so that Google Testing can run as well.

loic-sharma
loic-sharma approved these changes Jul 30, 2026
View reviewed changes

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice clean up, thanks!

@loic-sharma loic-sharma changed the title focus order dot shorthands Add dot shorthands support for focus order Jul 30, 2026
@FMorschel

FMorschel commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Are the failing tests related to this change?

@Piinks

Piinks commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Are the failing tests related to this change?

I don't think so. I am re-running to deflake.

@navaronbracke navaronbracke added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 5, 2026
Merged via the queue into flutter:master with commit 4adca2f Aug 5, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2026
This was referenced Aug 5, 2026
Closed
Closed
Closed
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2026
Closed
@Piinks Piinks mentioned this pull request Aug 8, 2026
Open
@navaronbracke
navaronbracke deleted the focus_traversal_order_dot_shorthand branch August 11, 2026 11:24
This was referenced Aug 11, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes
@FMorschel FMorschel Awaiting requested review from FMorschel
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add factory constructors to FocusOrder

4 participants

@navaronbracke @FMorschel @Piinks @loic-sharma