Repository navigation
Instruct gemini code assist not to comment on syntax error - #189930
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| - **Search for counter-examples**: Identify scenarios or edge cases that the proposed code does not handle. If a counter-example is found, propose a test case to demonstrate the gap. | ||
| - **Suggest simplification and refactoring**: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. | ||
|
|
||
| ### What Not to Report |
There was a problem hiding this comment.
It should still report them if the analyzer does though, right? Should we see how to teach the agent about new Dart features?
There was a problem hiding this comment.
If the error would have been caught by another presubmit anyway, the comment is just adding noise. It's like having two tests that run the exact same test.
Another reason is future proof. While I agree that it would be better to teach the agent about new Dart features so that it knows when to use them (and we should definitely add that when the Dart team publishes the official skill for that), with this change at least it won't add noise on things that it has outdated information about.
|
autosubmit label was removed for flutter/flutter/189930, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
94f0599 to
9649d92
Compare
Gemini doesn't know new Dart syntax, and is only adding noise in that case.