Sitelet https://github.com/flutter/flutter/pull/189602
Skip to content

ci(github-actions): resolve zizmor github-env findings in composite flutter actions - #189602

Merged
jtmcdole merged 1 commit into
masterfrom
zizmor-composite
Jul 16, 2026
Merged

jtmcdole merged 1 commit into
masterfrom
zizmor-composite

Conversation

@jtmcdole

Copy link
Copy Markdown
Member

fixes #189100

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 16, 2026
@jtmcdole
jtmcdole requested a review from eyebrowsoffire July 16, 2026 18:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the actions/checkout version to a specific commit hash across multiple workflows, adds persist-credentials: false to checkout steps, and refactors several shell scripts in GitHub Actions to use environment variables for inputs and zizmor ignore annotations. The review suggests updating inline comments for action versions to reflect the specific release tag and recommends consolidating redundant steps in the Android SDK setup and engine version redirection to improve readability and maintainability.

Comment thread .github/actions/composite-flutter-setup/action.yml
Comment thread .github/actions/composite-flutter-setup/action.yml
Comment thread .github/actions/wait-for-engine-build/action.yml

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole
jtmcdole added this pull request to the merge queue Jul 16, 2026
Merged via the queue into master with commit d8565c9 Jul 16, 2026
25 checks passed
@jtmcdole
jtmcdole deleted the zizmor-composite branch July 16, 2026 21:27
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 18, 2026
Roll Flutter from fc1ad955f164 to 8005793c3562 (40 revisions)

flutter/flutter@fc1ad95...8005793

2026-07-18 97480502+b-luk@users.noreply.github.com Remove `LineContents ` experimental AA line shader that is no longer used (flutter/flutter#189619)
2026-07-18 engine-flutter-autoroll@skia.org Roll Skia from 9468e96cc40f to ba90f98535de (8 revisions) (flutter/flutter#189680)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 33e4b71e984b to 666e1e2133b7 (2 revisions) (flutter/flutter#189673)
2026-07-17 chris@bracken.jp [iOS] Fix potential use-after-free in a11y bridge channel handler (flutter/flutter#189637)
2026-07-17 269567208+reidbaker-agent@users.noreply.github.com Migrate dev/tools skill validation to new dart_skills_lint API (flutter/flutter#189626)
2026-07-17 22373191+Hari-07@users.noreply.github.com Add validation for required fields during xcodebuild (flutter/flutter#187772)
2026-07-17 awolff@google.com Upgrade android_hardware_smoke_test CI to run instrumented tests (flutter/flutter#189390)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 0867cb1897b5 to 33e4b71e984b (1 revision) (flutter/flutter#189661)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 702c3e790232 to 9468e96cc40f (1 revision) (flutter/flutter#189660)
2026-07-17 engine-flutter-autoroll@skia.org Roll Packages from 9f95026 to 4fdc766 (11 revisions) (flutter/flutter#189659)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 2e4a3ae035cd to 702c3e790232 (1 revision) (flutter/flutter#189655)
2026-07-17 bernaferrari2@gmail.com [macOS] Add FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS (flutter/flutter#189614)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from c69d138c9646 to 0867cb1897b5 (2 revisions) (flutter/flutter#189649)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 4f5aca109c87 to 2e4a3ae035cd (3 revisions) (flutter/flutter#189646)
2026-07-17 chris@bracken.jp [iOS] Fix missing nil checks and improve SemanticsObject bridge API (flutter/flutter#189630)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 37c5e6b26aee to 4f5aca109c87 (19 revisions) (flutter/flutter#189638)
2026-07-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lLFbh5kFWbUGgC9Ek... to NL8xtzr8cxr5E8r8E... (flutter/flutter#189632)
2026-07-17 ishaquehassan@gmail.com Add blendMode parameter to RawImage and RenderImage (flutter/flutter#185938)
2026-07-17 1961493+harryterkelsen@users.noreply.github.com [web] Cache WASM network requests in flutter test (flutter/flutter#189623)
2026-07-17 awolff@google.com android_hardware_smoke_tests: Apply semantic line breaks to readme (flutter/flutter#189613)
2026-07-16 codefu@google.com ci(github-actions): resolve zizmor github-env findings in composite flutter actions (flutter/flutter#189602)
2026-07-16 stuartmorgan@google.com Remove obsolete packages analysis flag (flutter/flutter#189525)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from e24870ff15bc to c69d138c9646 (2 revisions) (flutter/flutter#189597)
2026-07-16 liyl@google.com [fuchsia][iwyu] Remove transitive include of fuchsia.input.report. (flutter/flutter#188891)
2026-07-16 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary value key hack in `key.dart`  (flutter/flutter#189291)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 81306a2ed317 to e24870ff15bc (1 revision) (flutter/flutter#189569)
2026-07-16 flar@google.com [Impeller] Fix atlas growth test (flutter/flutter#189533)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from d402ff7c9c84 to 81306a2ed317 (4 revisions) (flutter/flutter#189558)
2026-07-16 magder@google.com Move shared darwin plugin tests into own builder (flutter/flutter#189411)
2026-07-16 engine-flutter-autoroll@skia.org Roll Skia from ab2410bc857c to 37c5e6b26aee (19 revisions) (flutter/flutter#189549)
2026-07-16 chris@bracken.jp [ios] Fix //flutter:unittests build for physical devices (flutter/flutter#189543)
2026-07-16 digvijaysinghiam@gmail.com Fix lower DragTarget not being recognized in overlapping targets (flutter/flutter#188979)
2026-07-16 katelovett@google.com Relocate cupertino samples that were under widgets/ (flutter/flutter#188876)
2026-07-15 chris@bracken.jp [iOS] Migrate DisplayLinkManager to a shared instance (flutter/flutter#189492)
2026-07-15 jason-simmons@users.noreply.github.com [Impeller] Call glfwTerminate during global test environment teardown if a playground test called glfwInit (flutter/flutter#189523)
2026-07-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#189515)
2026-07-15 engine-flutter-autoroll@skia.org Roll Packages from ad2eab1 to 9f95026 (8 revisions) (flutter/flutter#189509)
2026-07-15 31859944+LongCatIsLooong@users.noreply.github.com add `@nonVirtual` to `RenderObject.attached`, fix `WidgetTester.hasRunningAnimations` (flutter/flutter#186832)
2026-07-15 jason-simmons@users.noreply.github.com Roll vulkan-deps to 0582f446e54a (flutter/flutter#188524)
2026-07-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 0c408ff6dce9 to d402ff7c9c84 (1 revision) (flutter/flutter#189497)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
...
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
…r#12241)

Roll Flutter from fc1ad955f164 to 8005793c3562 (40 revisions)

flutter/flutter@fc1ad95...8005793

2026-07-18 97480502+b-luk@users.noreply.github.com Remove `LineContents ` experimental AA line shader that is no longer used (flutter/flutter#189619)
2026-07-18 engine-flutter-autoroll@skia.org Roll Skia from 9468e96cc40f to ba90f98535de (8 revisions) (flutter/flutter#189680)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 33e4b71e984b to 666e1e2133b7 (2 revisions) (flutter/flutter#189673)
2026-07-17 chris@bracken.jp [iOS] Fix potential use-after-free in a11y bridge channel handler (flutter/flutter#189637)
2026-07-17 269567208+reidbaker-agent@users.noreply.github.com Migrate dev/tools skill validation to new dart_skills_lint API (flutter/flutter#189626)
2026-07-17 22373191+Hari-07@users.noreply.github.com Add validation for required fields during xcodebuild (flutter/flutter#187772)
2026-07-17 awolff@google.com Upgrade android_hardware_smoke_test CI to run instrumented tests (flutter/flutter#189390)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 0867cb1897b5 to 33e4b71e984b (1 revision) (flutter/flutter#189661)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 702c3e790232 to 9468e96cc40f (1 revision) (flutter/flutter#189660)
2026-07-17 engine-flutter-autoroll@skia.org Roll Packages from 9f95026 to 4fdc766 (11 revisions) (flutter/flutter#189659)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 2e4a3ae035cd to 702c3e790232 (1 revision) (flutter/flutter#189655)
2026-07-17 bernaferrari2@gmail.com [macOS] Add FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS (flutter/flutter#189614)
2026-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from c69d138c9646 to 0867cb1897b5 (2 revisions) (flutter/flutter#189649)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 4f5aca109c87 to 2e4a3ae035cd (3 revisions) (flutter/flutter#189646)
2026-07-17 chris@bracken.jp [iOS] Fix missing nil checks and improve SemanticsObject bridge API (flutter/flutter#189630)
2026-07-17 engine-flutter-autoroll@skia.org Roll Skia from 37c5e6b26aee to 4f5aca109c87 (19 revisions) (flutter/flutter#189638)
2026-07-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lLFbh5kFWbUGgC9Ek... to NL8xtzr8cxr5E8r8E... (flutter/flutter#189632)
2026-07-17 ishaquehassan@gmail.com Add blendMode parameter to RawImage and RenderImage (flutter/flutter#185938)
2026-07-17 1961493+harryterkelsen@users.noreply.github.com [web] Cache WASM network requests in flutter test (flutter/flutter#189623)
2026-07-17 awolff@google.com android_hardware_smoke_tests: Apply semantic line breaks to readme (flutter/flutter#189613)
2026-07-16 codefu@google.com ci(github-actions): resolve zizmor github-env findings in composite flutter actions (flutter/flutter#189602)
2026-07-16 stuartmorgan@google.com Remove obsolete packages analysis flag (flutter/flutter#189525)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from e24870ff15bc to c69d138c9646 (2 revisions) (flutter/flutter#189597)
2026-07-16 liyl@google.com [fuchsia][iwyu] Remove transitive include of fuchsia.input.report. (flutter/flutter#188891)
2026-07-16 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary value key hack in `key.dart`  (flutter/flutter#189291)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 81306a2ed317 to e24870ff15bc (1 revision) (flutter/flutter#189569)
2026-07-16 flar@google.com [Impeller] Fix atlas growth test (flutter/flutter#189533)
2026-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from d402ff7c9c84 to 81306a2ed317 (4 revisions) (flutter/flutter#189558)
2026-07-16 magder@google.com Move shared darwin plugin tests into own builder (flutter/flutter#189411)
2026-07-16 engine-flutter-autoroll@skia.org Roll Skia from ab2410bc857c to 37c5e6b26aee (19 revisions) (flutter/flutter#189549)
2026-07-16 chris@bracken.jp [ios] Fix //flutter:unittests build for physical devices (flutter/flutter#189543)
2026-07-16 digvijaysinghiam@gmail.com Fix lower DragTarget not being recognized in overlapping targets (flutter/flutter#188979)
2026-07-16 katelovett@google.com Relocate cupertino samples that were under widgets/ (flutter/flutter#188876)
2026-07-15 chris@bracken.jp [iOS] Migrate DisplayLinkManager to a shared instance (flutter/flutter#189492)
2026-07-15 jason-simmons@users.noreply.github.com [Impeller] Call glfwTerminate during global test environment teardown if a playground test called glfwInit (flutter/flutter#189523)
2026-07-15 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#189515)
2026-07-15 engine-flutter-autoroll@skia.org Roll Packages from ad2eab1 to 9f95026 (8 revisions) (flutter/flutter#189509)
2026-07-15 31859944+LongCatIsLooong@users.noreply.github.com add `@nonVirtual` to `RenderObject.attached`, fix `WidgetTester.hasRunningAnimations` (flutter/flutter#186832)
2026-07-15 jason-simmons@users.noreply.github.com Roll vulkan-deps to 0582f446e54a (flutter/flutter#188524)
2026-07-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 0c408ff6dce9 to d402ff7c9c84 (1 revision) (flutter/flutter#189497)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: harden flutter composite actions with zizmor

2 participants