Repository navigation
[web] Remove per-launch browser console listener from test harness - #189521
flutter-zl wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the unused webkit_inspection_protocol import and deletes the asynchronous block in BrowserManager that connected to the Chrome tab to listen for console API calls and exceptions. There are no review comments, and I have no feedback to provide.
|
Update on the cause. Short version: these shards are not slowly running over their time limit, they are getting stuck. What I found on web_canvaskit_tests_6:
Why this matters: because the shard is hanging, not running slow, bumping the timeout or adding shards will not fix it. It will just hang longer, or hang somewhere else. The real fix is figuring out why Chrome 145 sometimes freezes while loading a test. Side note: I tried removing the console listener the roll added (#189521) in case it was the cost. It is not, master still has that listener and hangs the same way, so that is ruled out. @harryterkelsen @kevmoo any idea what in Chrome 145 headless could make it randomly freeze while loading a test? |
Draft, do not merge. Measurement only for #189275. Removes the per-launch browser console listener added in #182861 to see whether it recovers meaningful time on the web test shards. If it does, the landable version would gate the listener behind verbose mode rather than delete it.