Repository navigation
Run Mac golden tests on ARM bots - #189465
Merged
Merged
Conversation
jmagman
marked this pull request as ready for review
July 14, 2026 22:40
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
8 of 18 tasks
gaaclarke
approved these changes
Jul 21, 2026
gaaclarke
left a comment
Member
There was a problem hiding this comment.
LGTM, i overlooked the golden changes and the all look fine to me too.
Contributor
|
autosubmit label was removed for flutter/flutter/189465, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 28, 2026
flutter/flutter@9988960...0f02463 2026-07-28 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from E8hJ1AfK8CtGtaES0... to 1frGe_KltAJKkeyPg... (flutter/flutter#190134) 2026-07-28 chris@bracken.jp iOS: Reject merged-platform-ui-thread=mergeAfterLaunch (flutter/flutter#190051) 2026-07-28 chris@bracken.jp iOS: Migrate TaskRunner tests to Swift Testing (flutter/flutter#190055) 2026-07-28 magder@google.com Run Mac golden tests on ARM bots (flutter/flutter#189465) 2026-07-28 chris@bracken.jp iOS,macOS: Rename Swift test files to end in Tests.swift (flutter/flutter#190063) 2026-07-28 34871572+gmackall@users.noreply.github.com Fix hcpp cliprect being behind by 1 frame when scrolling (flutter/flutter#189946) 2026-07-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vpboK5fPPIoFteqRq... to OZkZC_2CZ_G5rbMIS... (flutter/flutter#190115) 2026-07-27 ishaquehassan@gmail.com Add Ishaq Hassan to AUTHORS (flutter/flutter#190064) 2026-07-27 30870216+gaaclarke@users.noreply.github.com [wimp] fixes ubo padding size issue (flutter/flutter#189958) 2026-07-27 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#189872) 2026-07-27 magder@google.com Move tool host_cross_arch tests into different shards (flutter/flutter#189470) 2026-07-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6.2.0 to 7.0.0 in the all-github-actions group (flutter/flutter#190099) 2026-07-27 41930132+hellohuanlin@users.noreply.github.com [ios]do not nuke user input path when running uiscene integration test (flutter/flutter#186436) 2026-07-27 codefu@google.com ci: verify_binaries_pre_codesigned part 2 (flutter/flutter#190078) 2026-07-27 jason-simmons@users.noreply.github.com Roll Abseil to ff6e8ce3e932 (flutter/flutter#189998) 2026-07-27 awolff@google.com Android_hardware_smoke_test: clean up golden copy in CI (flutter/flutter#189948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel bots are being deprecated. Pin the builds that generate goldens to ARM instead of Intel (see #119880). This PR indeed generated new goldens as described in #119880.
Fixes #119880
Part of #189144
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.