Sitelet https://github.com/flutter/flutter/pull/189364
Skip to content

Use ServicesBinding.instance.exitApplication instead of exit(0) in multiple_windows example - #189364

Merged
robert-ancell merged 1 commit into
flutter:masterfrom
canonical:correct-exit
Jul 14, 2026
Merged

Use ServicesBinding.instance.exitApplication instead of exit(0) in multiple_windows example#189364
robert-ancell merged 1 commit into
flutter:masterfrom
canonical:correct-exit

Conversation

@mattkae

@mattkae mattkae commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What's new?

  • Exactly what the title says :)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 13, 2026
@github-actions github-actions Bot added the d: examples Sample code and demos label Jul 13, 2026
@flutter-dashboard

flutter-dashboard Bot commented Jul 13, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies examples/multiple_windows/lib/main.dart by replacing the dart:io import with dart:ui and package:flutter/services.dart. It updates the onWindowDestroyed method to use ServicesBinding.instance.exitApplication(AppExitType.required) instead of calling exit(0). There are no review comments, and I have no feedback to provide.

@Piinks Piinks added the a: desktop Running on desktop label Jul 13, 2026
robert-ancell
robert-ancell approved these changes Jul 14, 2026
View reviewed changes

@robert-ancell robert-ancell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks more correct.

@robert-ancell
robert-ancell added this pull request to the merge queue Jul 14, 2026
Merged via the queue into flutter:master with commit e28a642 Jul 14, 2026
66 checks passed
@robert-ancell
robert-ancell deleted the correct-exit branch July 14, 2026 22:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 15, 2026
@engine-flutter-autoroll
Roll Flutter from 846664bf191a to fc1ad955f164 (18 revisions) (#12203)
7aa1761 
flutter/flutter@846664b...fc1ad95

2026-07-15 chris@bracken.jp [iOS] Migrate FlutterKeyboardInsetManager to Swift (flutter/flutter#189425)
2026-07-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 05bf153370c4 to 0c408ff6dce9 (4 revisions) (flutter/flutter#189487)
2026-07-15 97480502+b-luk@users.noreply.github.com Implement UberSDF lines to replace LineContents-based AA lines (flutter/flutter#188514)
2026-07-15 66727653+ishaq2321@users.noreply.github.com Fix stale eagerWinner reference in GestureArenaManager when rejected before arena close (flutter/flutter#187008)
2026-07-15 jason-simmons@users.noreply.github.com Disable some Windows tests that are flaking on CI (flutter/flutter#189477)
2026-07-15 dmgr Added unified check-run user manual (flutter/flutter#189453)
2026-07-15 engine-flutter-autoroll@skia.org Roll Skia from 88954ef8f36d to ab2410bc857c (9 revisions) (flutter/flutter#189474)
2026-07-14 1961493+harryterkelsen@users.noreply.github.com [agents] Refactor shepherd-prs skill into a pure Markdown runbook using native gh CLI (flutter/flutter#189095)
2026-07-14 6655696+guidezpl@users.noreply.github.com Add missing name to mirroring workflow (flutter/flutter#189439)
2026-07-14 biggs0125@gmail.com Add support for WASM deferred loading. (flutter/flutter#189308)
2026-07-14 116356835+AbdeMohlbi@users.noreply.github.com fix `templateDefaultGradleVersion` todo (flutter/flutter#189466)
2026-07-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from oOETA0ISPouDt2xBo... to lLFbh5kFWbUGgC9Ek... (flutter/flutter#189469)
2026-07-14 matt.kosarek@canonical.com Use ServicesBinding.instance.exitApplication instead of exit(0) in multiple_windows example (flutter/flutter#189364)
2026-07-14 chingjun@google.com Add CpuArch to the Device class (flutter/flutter#189207)
2026-07-14 bkonyi@google.com Fix space formatting in cherry-pick label for flutter_cp.dart (flutter/flutter#189463)
2026-07-14 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#189454)
2026-07-14 44747303+theprantadutta@users.noreply.github.com [flutter_tools] Format plugin example template to match dart format (flutter/flutter#188382)
2026-07-14 magder@google.com Move renamed x64->ARM benchmarks out of bringup (flutter/flutter#189400)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes
@knopp knopp Awaiting requested review from knopp
@loic-sharma loic-sharma Awaiting requested review from loic-sharma
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop CICD Run CI/CD d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattkae @robert-ancell @Piinks