Repository navigation
refactor(web): SkwasmPath and SkwasmPathBuilder separation - #189086
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Skwasm path implementation by separating path building logic into a new SkwasmPathBuilder class, while SkwasmPath now only represents the immutable path. It also adds comprehensive unit tests for various path-building operations. The review feedback suggests adding an assertion in SkwasmPathBuilder.build to prevent use-after-free bugs, and guarding the dispose method with an active check on _isDisposed to avoid double-free issues in release builds where assertions are disabled.
Swiftaxe
force-pushed
the
refactor_skwasmpath
branch
2 times, most recently
from
July 9, 2026 16:51
18d90bb to
3fcf0f8
Compare
Swiftaxe
force-pushed
the
refactor_skwasmpath
branch
from
July 9, 2026 19:42
3fcf0f8 to
9474827
Compare
mdebbar
approved these changes
Aug 12, 2026
mdebbar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clean refactor!
mdebbar
approved these changes
Aug 12, 2026
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkwasmPath was implementing both the immutable and mutable interfaces.
To separate concerns, SkwasmPath now implements the immutable interface, and a SkwasmPathBuilder class is added for the mutable interface.
Also, test coverage improved to verify that nothing breaks.
Closes #184840
Pre-launch Checklist
///).