Suggest the -d flag after interactive device selection - #188941

Hi @theprantadutta! Do you plan on coming back to this PR?

Yes, definitely — sorry for the silence on it. This has been sitting as a draft for one reason only: as a non-committer I can have at most two open non-draft PRs, and #188939 and #188940 currently hold both slots (both are mid-review). So it's parked rather than abandoned.

The work itself is finished and still healthy — I re-checked just now:

• no merge conflicts against master
• target_devices_test.dart passes 97/97, including the 17 expectations updated for the new hint

I'll flip it to ready the moment one of the other two lands. If you'd rather look at it sooner, say the word and I'll flip it straight away — happy to let one of the others go back to draft to free the slot if that's the preferred order.

@bkonyi following up on your question from Aug 18 — a slot freed up when #188940 merged today, so this is now marked ready for review.

Nothing has changed since you asked: no merge conflicts, and target_devices_test.dart passes 97/97 including the 17 expectations updated for the new hint.

Thanks for the reviews @bkonyi @chingjun 🙏

Heads-up on why there's a new commit after your approvals: the ci.yaml validation check was failing. The cause wasn't the change itself — this branch was opened in early July and had drifted 187 commits behind, so it was still carrying an old .ci.yaml (master's has moved by roughly +941/-438 lines since). I merged master in (5940448) and .ci.yaml is now identical to master's, which should clear that check.

The PR diff is unchanged by the merge — still only the two files, and target_devices_test.dart passes 98/98 (one more than before; master added a case). Both of your approvals carried over to the new head.

One thing I can't do from my side: pushing dropped the CICD label, and I don't have permission to add labels back (403 Must have admin rights). Could someone re-apply CICD, and autosubmit once the checks are green?

autosubmit label was removed for flutter/flutter/188941, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

The autosubmit label came off again on Sep 2 because Dashboard Checks failed. I dug into the actual build rather than assuming it was a flake, and I believe it is one — details so someone can decide quickly:

The only failing job is Linux web_skwasm_tests_0 (build 8671822780029516161). Buildbucket reports:

status        : INFRA_FAILURE
statusDetails : {"timeout": {}}
summary       : The build was cancelled: Step('run test.dart for web_skwasm_tests shard and subshard 0')
start / end   : 23:14:05Z → 23:59:16Z  (~45 min, then cancelled)

So it wasn't a test assertion — the shard ran to its timeout and was cancelled, which buildbucket classifies as infrastructure rather than failure. Its sibling shard Linux web_skwasm_tests_1 passed on the same commit, and every other check on this PR is green.

This PR only touches flutter_tools device selection (target_devices.dart and its test), which has no path to the web/skwasm renderer tests.

Could someone re-run that one job and re-apply autosubmit? I can't do either from here (403 Must have admin rights on labels). Both approvals are still active on the current head.

autosubmit label was removed for flutter/flutter/188941, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.