Repository navigation
Add more 0x0 size tests part 12 - #187529
auto-submit[bot] merged 17 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds tests to verify that several widgets, including 'Baseline', 'IgnoreBaseline', 'PositionedDirectional', 'Flexible', 'Expanded', 'Flex', 'Positioned', and 'Stack', do not crash when laid out in a zero-area environment. Feedback from the reviewer suggests that for 'ParentDataWidget's like 'Flexible', 'Expanded', 'Positioned', and 'PositionedDirectional', the tests should assert the size of their parent widgets rather than querying their sizes directly. Additionally, the reviewer recommends adding positioning arguments to 'Positioned' and 'PositionedDirectional' to ensure the positioned layout code path is properly exercised.
|
Hi @ahmedsameha1 when you get a chance can you rebase your branch to the latest master to fix the "ci.yaml validation". Thank you! |
|
autosubmit label was removed for flutter/flutter/187529, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/flutter/187529, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This is my attempt to handle #6537 for the following widgets:
Baseline
IgnoreBaseline
Stack
Positioned
PositionedDirectional
Flex
Row
Column
Flexible
Expanded