Add Gemini Code Assist review config and style guide by jmagman · Pull Request #172785 · flutter/flutter

jmagman · 2025-07-25T20:36:48Z

Initial config files for Gemini Code Assist for GitHub. These config files are modified versions of the one already added to the flutter/packages repo: [ci] Add Gemini Code Assist review config packages#9632 based on the official docs.
Style guide has links to various contributing docs and style guides.
Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See Have Gemini ignore Flutter version pin packages#9647.
Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in [ci] Add Gemini Code Assist review config packages#9632.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jtmcdole · 2025-07-25T21:33:17Z

+ignore_patterns:
+  # Avoid code reviews on rolls.
+  - DEPS
+  - bin/internal/**


is bin/internal a roll? that's our shell scripts (bash/powershell).

It includes .version files that are rolled. For example #172696.

I will update the pattern to include .version

jtmcdole

lgtm from a "launch and learn"

jmagman · 2025-07-25T22:16:21Z

+- Python code is formatted using `yapf`, linted with `pylint`, and should follow the [Google Python Style Guide](https://google.github.io/styleguide/pyguide.html).
+- C++ code is formatted using `clang-format`, linted with `clang-tidy`, and should follow the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html).
+- Shaders are formatted using `clang-format`.
+- Kotlin code is formatted using `ktformat`, linted with `ktlint`, and should follow the [Android Kotlin Style Guide](https://developer.android.com/kotlin/style-guide).


ktformat isn't actually used yet, but that's the goal #138349.

jmagman · 2025-07-25T22:24:03Z

+- Kotlin code is formatted using `ktformat`, linted with `ktlint`, and should follow the [Android Kotlin Style Guide](https://developer.android.com/kotlin/style-guide).
+- Java code is formatted using `google-java-format` and should follow the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html).
+- Objective-C is formatted using `clang-format`, linted with `clang-tidy`, and should follow the [Google Objective-C Style Guide](https://google.github.io/styleguide/objcguide.html).
+- Swift is formatted using `swift-format` and should follow the [Google Swift Style Guide](https://google.github.io/swift).


Same, this is an aspirational comment, Swift isn't formatted or linted yet #172799

stuartmorgan-g

LGTM based on my vast expertise in this domain 🙃

…/flutter#172785)

flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. #172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in #172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. flutter#172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in flutter#172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. flutter#172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in flutter#172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. flutter#172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in flutter#172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

…/flutter#172785)

- Initial config files for [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). These config files are modified versions of the one already added to the flutter/packages repo: flutter/packages#9632 based on [the official docs](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). - Style guide has links to various contributing docs and style guides. - Ignore paths associated with version pins and third_party to avoid reviews on rolls and code that doesn't need modification. See flutter/packages#9647. - Add a note to the PR template to provide some notice/guidance to contributors about how to use automated feedback, to clarify the role of the automated reviews and hopefully minimize potential issues in case the bot leaves incorrect feedback. This is a direct copy of the comment introduced in flutter/packages#9632. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. flutter#172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in flutter#172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from 963550c to 6b2e34e (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@cfbaa18...46b097a 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (#172783)" (flutter/flutter#172900) 2025-07-29 a-siva@users.noreply.github.com Manual roll of Dart from 5ede85aff798 to 14ea8d342149 (flutter/flutter#172783) 2025-07-29 chingjun@google.com Revert "Remove 2023 deprecated `'platforms'` key from daemon output (#172593)" (flutter/flutter#172883) 2025-07-29 flar@google.com Migrate Embedder code to impeller/DL geometry classes (flutter/flutter#172804) 2025-07-28 bdero@google.com [Flutter GPU] Fix Android/GLES crashers. (flutter/flutter#172588) 2025-07-28 engine-flutter-autoroll@skia.org Roll Packages from f9acfba to 7c3e2d3 (7 revisions) (flutter/flutter#172869) 2025-07-28 30870216+gaaclarke@users.noreply.github.com Reland licenses cpp switch (flutter/flutter#172671) 2025-07-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Add --no-codesign support for macOS build (#169034)" (flutter/flutter#172878) 2025-07-28 matej.knopp@gmail.com [flutter_tools] Add --no-codesign support for macOS build (flutter/flutter#169034) 2025-07-28 stuartmorgan@google.com Add `--config-only` build option for Linux and Windows (flutter/flutter#172239) 2025-07-28 magder@google.com Add Gemini Code Assist review config and style guide (flutter/flutter#172785) 2025-07-28 41930132+hellohuanlin@users.noreply.github.com [ios]update provisioning profile for 2025-2026 cert for chromium bots (flutter/flutter#171021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gemini Code Assist for GitHub config seems incorrect, though the comment doesn't tell us what's wrong. flutter/flutter#172886 (comment) <img width="814" height="111" alt="Screenshot 2025-07-28 at 4 45 41 PM" src="/sitelet?url=https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F%253Ca%2520href%3D"/sitelet?url=https%3A%2F%2Fgithub.com%2Fuser-attachments%2Fassets%2F6763a74b-3b14-4ef0-8234-4eaa70a72358">https://github.com/user-attachments/assets/6763a74b-3b14-4ef0-8234-4eaa70a72358" /> Speculating the yaml doesn't like the `**`. Introduced in flutter/flutter#172785 --------- Co-authored-by: John "codefu" McDole <john@mcdole.org> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: John "codefu" McDole <codefu@google.com>

jmagman self-assigned this Jul 25, 2025

jmagman added 6 commits July 25, 2025 14:30

Add Gemini Code Assist review config and style guide

f73141c

pull request comment

0817160

Add more details

eb48b76

add ignore_patterns for rolls and third_party

f7b85ba

main

dffb1fd

trailing

e4b1acd

jmagman force-pushed the gemini-config branch from 63c2a73 to e4b1acd Compare July 25, 2025 21:31

jtmcdole reviewed Jul 25, 2025

View reviewed changes

jtmcdole approved these changes Jul 25, 2025

View reviewed changes

Comment thread .gemini/styleguide.md Outdated

Comment thread .gemini/styleguide.md

Add format, lint, and style guides for non-dart languages

8aaad65

jmagman marked this pull request as ready for review July 25, 2025 22:14

jmagman requested a review from stuartmorgan-g July 25, 2025 22:14

jmagman commented Jul 25, 2025

View reviewed changes

jtmcdole approved these changes Jul 25, 2025

View reviewed changes

Comment thread .gemini/styleguide.md

Add swift-format lint

449cad6

jmagman mentioned this pull request Jul 25, 2025

Format markdown files #172801

Open

stuartmorgan-g approved these changes Jul 26, 2025

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2025

auto-submit Bot added this pull request to the merge queue Jul 28, 2025

Merged via the queue into flutter:master with commit b2cc192 Jul 28, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2025

jmagman deleted the gemini-config branch July 28, 2025 22:01

jmagman mentioned this pull request Jul 28, 2025

Fix Gemini Code Assist for GitHub config yaml #172887

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2025

b2cc192 Add Gemini Code Assist review config and style guide (flutter…

9d996ef

…/flutter#172785)

engine-flutter-autoroll mentioned this pull request Jul 29, 2025

Roll Flutter from cfbaa18bdecc to 9ceb7614fa94 (11 revisions) flutter/packages#9693

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2025

b2cc192 Add Gemini Code Assist review config and style guide (flutter…

8fe7070

…/flutter#172785)

engine-flutter-autoroll mentioned this pull request Jul 29, 2025

Roll Flutter from cfbaa18bdecc to 46b097a3070d (12 revisions) flutter/packages#9695

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

b2cc192 Add Gemini Code Assist review config and style guide (flutter…

7937fcc

…/flutter#172785)

Navigation Menu

Repository navigation

Add Gemini Code Assist review config and style guide - #172785

Add Gemini Code Assist review config and style guide#172785
auto-submit[bot] merged 8 commits into
flutter:masterfrom
jmagman:gemini-config

jmagman commented Jul 25, 2025 •

edited

Loading

Uh oh!

jtmcdole Jul 25, 2025

Uh oh!

jmagman Jul 25, 2025

Uh oh!

jmagman Jul 25, 2025

Uh oh!

jtmcdole left a comment

Uh oh!

Uh oh!

Uh oh!

jmagman Jul 25, 2025

Uh oh!

jmagman Jul 25, 2025

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmagman commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jtmcdole Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmagman Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

jmagman Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Jul 25, 2025 •

edited

Loading