Sitelet https://github.com/flutter/flutter/pull/166205/files
Skip to content

[Impeller] remove validation warning ignores. #166205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Mar 31, 2025
Merged

[Impeller] remove validation warning ignores. #166205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions engine/src/flutter/impeller/renderer/backend/vulkan/debug_report_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,21 +117,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
if (data->messageIdNumber == 0x609A13B) {
return Result::kContinue;
}
// TODO(149111): Fix VUID-VkShaderModuleCreateInfo-pCode-08737.
if (data->pMessageIdName != nullptr &&
strcmp(data->pMessageIdName,
"VUID-VkShaderModuleCreateInfo-pCode-08737") == 0) {
return Result::kContinue;
}
// TODO(149111): Fix
// VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849.
if (data->pMessageIdName != nullptr &&
strcmp(
data->pMessageIdName,
"VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849") ==
0) {
return Result::kContinue;
}

// This warning happens when running tests that use SwiftShader.
// Some SPIR-V shaders request the UniformAndStorageBuffer16BitAccess
Expand All @@ -145,7 +130,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
std::vector<std::pair<std::string, std::string>> items;

items.emplace_back("Severity", vk::to_string(severity));

items.emplace_back("Type", vk::to_string(type));

if (data->pMessageIdName) {
Expand Down