Deprecates string for reorderable list in material_localizations by chunhtai · Pull Request #124711 · flutter/flutter

chunhtai · 2023-04-12T17:39:34Z

deprecates the these strings since they are now moved into widgetslocalizations

migration guide https://github.com/flutter/website/pull/8543/files

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2023-04-12T19:32:21Z

@Piinks I can't think of a way to write dart fixes.

I think there are two cases

MaterialLocalizations.of(context).reorderItemToStart

to

WidgetsLocalizations.of(context).reorderItemToStart

final MaterialLocalizations localizations = MaterialLocalizations.of(context);

localizations.reorderItemToStart;
localizations.expandedIconTapHint;

to

final MaterialLocalizations localizations = MaterialLocalizations.of(context);
final WidgetsLocalizations widgetsLocalizations = WidgetsLocalizations.of(context);

widgetsLocalizations.reorderItemToStart;
localizations.expandedIconTapHint;

I don't think 2 is possible given there may be a lot of corner cases.

but even for 1, I am not sure how to correctly capture it

Piinks

I agree, this one is difficult to reliably capture with dart fix, but simple enough with a migration guide.
You may be able to fix case 1 by using replacedBy, this dart fix feature has not been used a lot, but was added for this case.

The .of method of MaterialLocalizations would be replacedBy WidgetsLocalizations.

Probably like:

# Changes made in https://github.com/flutter/flutter/pull/124711
  - title: "Migrate to ..."
    date: ...
    element:
      uris: [ ...]
      method: 'of'
      inClass: 'MaterialLocalizations'
    changes:
      - kind: 'replacedBy'
        newElement:
          uris: [ ...]
          method: 'of'
          inClass: 'WidgetLocalizations'

chunhtai · 2023-04-13T18:42:43Z

For case one, I need to make sure they are accessing the deprecating string after the .of(context). For example

MaterialLocalizations.of(context).reorderItemToStart

Is there a condition API for this?

Piinks · 2023-04-13T18:44:47Z

Oh right! 🤦‍♀️
This one always gets me.

Nope, dart fix cannot do this. We just examined this with the window deprecations.

Piinks

LGTM since it is not dart fixable. In that case, we should definitely add a simple migration guide to the website.

Also, I am surprised the bot did not ask for tests. I reached out in the infra channel to see if the bot is ok or OOO. ;)

…ons (flutter/flutter#124711)

Manual roll requested by ychris@google.com flutter/flutter@50171bb...15cb1f8 2023-04-17 tessertaha@gmail.com Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673) 2023-04-17 47866232+chunhtai@users.noreply.github.com Deprecates string for reorderable list in material_localizations (flutter/flutter#124711) 2023-04-17 jhy03261997@gmail.com Fix a null crash in SelectableRegion Widget (flutter/flutter#124736) 2023-04-17 54718862+mub-pro@users.noreply.github.com Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987) 2023-04-17 godofredoc@google.com Remove token permissions for coverage. (flutter/flutter#124909) 2023-04-17 engine-flutter-autoroll@skia.org Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#124711 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/master/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com>

Manual roll requested by ychris@google.com flutter/flutter@50171bb...15cb1f8 2023-04-17 tessertaha@gmail.com Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673) 2023-04-17 47866232+chunhtai@users.noreply.github.com Deprecates string for reorderable list in material_localizations (flutter/flutter#124711) 2023-04-17 jhy03261997@gmail.com Fix a null crash in SelectableRegion Widget (flutter/flutter#124736) 2023-04-17 54718862+mub-pro@users.noreply.github.com Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987) 2023-04-17 godofredoc@google.com Remove token permissions for coverage. (flutter/flutter#124909) 2023-04-17 engine-flutter-autoroll@skia.org Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Manual roll requested by ychris@google.com flutter/flutter@50171bb...15cb1f8 2023-04-17 tessertaha@gmail.com Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673) 2023-04-17 47866232+chunhtai@users.noreply.github.com Deprecates string for reorderable list in material_localizations (flutter/flutter#124711) 2023-04-17 jhy03261997@gmail.com Fix a null crash in SelectableRegion Widget (flutter/flutter#124736) 2023-04-17 54718862+mub-pro@users.noreply.github.com Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987) 2023-04-17 godofredoc@google.com Remove token permissions for coverage. (flutter/flutter#124909) 2023-04-17 engine-flutter-autoroll@skia.org Roll Packages from 789160c to 0300012 (9 revisions) (flutter/flutter#124972) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 12, 2023

chunhtai force-pushed the deprecate branch from c22d900 to 7c5af91 Compare April 12, 2023 19:28

chunhtai requested a review from Piinks April 12, 2023 22:39

chunhtai mentioned this pull request Apr 12, 2023

Adds migration guide for material localized Strings flutter/website#8543

Merged

3 tasks

chunhtai marked this pull request as ready for review April 12, 2023 22:41

Piinks reviewed Apr 13, 2023

View reviewed changes

Piinks approved these changes Apr 13, 2023

View reviewed changes

chunhtai force-pushed the deprecate branch from e8862dc to a1f8307 Compare April 13, 2023 19:52

chunhtai added 2 commits April 17, 2023 11:29

Deprecates reorderable strings in material localizations

ac96f77

analyzer

76ffbca

chunhtai force-pushed the deprecate branch from a1f8307 to 76ffbca Compare April 17, 2023 18:29

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023

auto-submit Bot merged commit 7424f34 into flutter:master Apr 17, 2023

engine-flutter-autoroll mentioned this pull request Apr 17, 2023

Manual roll Flutter from 50171bbae357 to 15cb1f84d726 (9 revisions) flutter/packages#3749

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2023

7424f34 Deprecates string for reorderable list in material_localizati…

c42ce35

…ons (flutter/flutter#124711)

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

reidbaker mentioned this pull request Apr 21, 2023

Test AGP 8.0 using java 17 #125323

Merged

8 tasks done

Navigation Menu

Deprecates string for reorderable list in material_localizations - #124711

Deprecates string for reorderable list in material_localizations#124711
auto-submit[bot] merged 2 commits into
flutter:masterfrom
chunhtai:deprecate

chunhtai commented Apr 12, 2023 •

edited

Loading

Uh oh!

chunhtai commented Apr 12, 2023

Uh oh!

Piinks left a comment •

edited

Loading

Uh oh!

chunhtai commented Apr 13, 2023

Uh oh!

Piinks commented Apr 13, 2023

Uh oh!

Piinks left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chunhtai commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai commented Apr 12, 2023

Uh oh!

Piinks left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai commented Apr 13, 2023

Uh oh!

Piinks commented Apr 13, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chunhtai commented Apr 12, 2023 •

edited

Loading

Piinks left a comment •

edited

Loading