Repository navigation
Update to latest Flutter SDK version - #9018
Merged
Merged
Conversation
elliette
marked this pull request as ready for review
March 11, 2025 18:13
Member
|
Is there a path forward on a fix for https://issues.chromium.org/issues/396208308? This renders our wasm benchmarks useless if we can't detect a real regression in performance for our users. This is okay if it is temporarily but I'd be concerned if we don't have a path forward here @eyebrowsoffire @yjbanov @kevmoo |
kenzieschmoll
approved these changes
Mar 11, 2025
Contributor
Yeah, this makes me sad. We should FIX this! |
Contributor
|
Paging in old cache. We'll keep tracking w/ the chrome folks for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Updates benchmark test numbers for wasm due to https://issues.chromium.org/issues/396208308 (Flutter SDK change: flutter/flutter#163175)