Fix Qodana-flagged possible multiple enumeration and unused auto-property warnings - #3300
Merged
Merged
Conversation
…uto-property accessors - BeProperSubsetOf/BeProperSupersetOf now materialize the expected collection once instead of enumerating it multiple times. - Mark test-only DTO properties with [UsedImplicitly] to suppress false-positive unused-accessor warnings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
dennisdoomen
had a problem deploying
to
qodana-pr
August 10, 2026 12:38 — with 
GitHub Actions
Failure
Test Results 37 files ±0 37 suites ±0 2m 48s ⏱️ -6s Results for commit d47f7dc. ± Comparison against base commit 7c5f77a. This pull request removes 10 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
PR #3293 added the BeJsonSerializable extension methods but the net6.0 approved-API baseline was never updated, causing the Approval.Tests.ApiApproval test (and thus the Build pipeline) to fail on main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Coverage Report for CI Build 31398681247Warning No base build found for commit Coverage: 97.183%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
jnyrup
approved these changes
Aug 10, 2026
4 of 9 tasks
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This was referenced Sep 14, 2026
Open
Closed
This was referenced Oct 2, 2026
Open
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Qodana workflow on
mainhas been failing (fail threshold 0) due to 10 new problems introduced by recent PRs:GenericCollectionAssertions.BeProperSubsetOf/BeProperSupersetOf— theexpectedProperSuperset/expectedProperSubsetparameters were enumerated more than once (once inside the sharedAssertSubsetOf/AssertContainmenthelper, again viaConvertOrCastToSet(), and again when passed toFailWith).ObjectAssertionSpecs.BeJsonSerializable.cstest helper DTOs, whose properties are only ever set (never read) but are required for JSON round-trip testing.Changes
BeProperSubsetOf/BeProperSupersetOfnow materialize the expected collection once into anICollection<T>and derive anyISet<T>needed for comparisons from that materialized collection, instead of re-enumerating the originalIEnumerable<T>parameter multiple times. Error messages and null-argument guard messages are unchanged.[UsedImplicitly](already used elsewhere in this file) to the test DTO properties flagged as unused, since they're populated via JSON serialization/object initializers rather than read directly.Verification
dotnet buildsucceeds with 0 warnings/errors.dotnet testfor theCollectionsandBeJsonSerializablespecs: all pass (928/928 on net6.0/net8.0, 906/906 on net47).AcceptApiChangesrun needed.