Repository navigation
in_tail: extract line parsing and emitting into LineFeeder - #5520
Conversation
|
Thanks for the refactoring. Right now it breaks plugins that inherit Could you keep Here are the plugins that inherit
There may also be private plugins that do the same.... |
|
Oops, there are more plugins that depend on |
5e05c00 to
17accd3
Compare
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Separate line parsing and event emission from TailInput's watcher lifecycle. This prepares in_tail for managing per-file processing state independently and future concurrent file processing without changing the current behavior. Keep TailInput's line-processing methods as compatibility entry points so plugins inheriting TailInput can continue to override them. Add regression tests for the existing entry points and subclass overrides. **Docs Changes**: None **Release Note**: None Assisted-by: LLM Qwen3.8-Flash-Next Signed-off-by: Takuro Ashie <ashie@clear-code.com>
17accd3 to
a690c93
Compare
|
I've revived compatibility endpoints for third party plugins. |
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Separate line parsing and event emission from TailInput's watcher
lifecycle. This prepares in_tail for managing per-file processing state
independently and future concurrent file processing without changing the
current behavior.
Keep TailInput's line-processing methods as compatibility entry points so
plugins inheriting TailInput can continue to override them.
Add regression tests for the existing entry points and subclass overrides.
Docs Changes:
None
Release Note:
None
Assisted-by: LLM Qwen3.8-Flash-Next