Sitelet https://github.com/firebase/flutterfire/pull/18752
Skip to content

fix(firebaseai): keep LiveSession.receive() open after an unparseable message - #18752

Open
Seungpyo1007 wants to merge 1 commit into
firebase:mainfrom
Seungpyo1007:fix/firebase-ai-live-receive
Open

Seungpyo1007 wants to merge 1 commit into
firebase:mainfrom
Seungpyo1007:fix/firebase-ai-live-receive

Conversation

@Seungpyo1007

Copy link
Copy Markdown

Description

LiveSession.receive() is an async* generator over await for (final result in _messageController.stream). When the server sends a message that parseServerResponse doesn't know, for example the voiceActivity message from gemini-3.8-live, _listenToWebSocket adds a FirebaseAISdkException to the controller. await for then rethrows it inside the generator, so the listener gets onError and then onDone, even though the WebSocket and the controller are still open and the model keeps answering.

This switches the loop to yield* _messageController.stream. yield* forwards the error as an error event and keeps listening, so one unparseable frame becomes a single error event instead of ending the stream. The doc comment on receive() now says so.

This doesn't add a type for voiceActivity itself. I asked about that on the issue, since it would be new public API.

Related Issues

Fixes #18749

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR. (ran flutter analyze on firebase_ai)
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

The new test in live_session_test.dart sends a valid message, a voiceActivity message and another valid message, then checks that the listener gets data, an error and data, with no onDone. It fails on main and passes with this change. The full firebase_ai suite passes (353 tests), and flutter analyze is clean for the package.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_ai] LiveSession.receive() ends on gemini-3.8-live's voiceActivity message (unhandled format) — every spoken turn kills the stream

1 participant