Conversation
There was a problem hiding this comment.
Code Review
This pull request implements support for signed post policy uploads in the GCS emulator by adding a new POST endpoint and a custom multipart/form-data parser. The feedback identifies a bug where the parser could truncate data if a trailing line separator is missing and suggests adding a verification check. Additionally, the reviewer recommends against trimming custom metadata values to maintain parity with GCS behavior and suggests making the boundary extraction logic more robust to handle extra Content-Type parameters.
|
Thanks for submitting this PR @7hokerz! I don't have a good understanding of the Storage emulator, but let me try checking with our engineering team to see if anyone more familiar with the Storage emulator would be able to take a look. Just to set expectations, we're going on a code freeze, so it might take some time for this PR to get merged. |
@aalej , Thank you for your response. I will gladly wait until a storage emulator expert is available. I appreciate your assistance! |
annajowang
left a comment
There was a problem hiding this comment.
(i am also not a "storage emulator expert". I don't think there currently is one. but if bugs come up after this is merged they can always be fixed)
Left some comments, please address them and the gemini ones as well.
Thanks for your contribution!
@annajowang , Thank you for your feedback! I will take the time to review it and make improvements soon. |
|
Note that @google-cloud/storage v7.21.0 is officially out, resolving the path-related issues. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
|
@aalej , @annajowang , It's been open for a while, and I want to make sure it didn't slip through the cracks. Whenever you have a moment, I'd appreciate your review so I can move forward. Thanks! |
annajowang
left a comment
There was a problem hiding this comment.
(sorry for the delay, i was out of office)
thanks for the changes
|
@annajowang , I apologize for the test failure. Could you please re-run the CI? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10490 +/- ##
=======================================
Coverage ? 57.79%
=======================================
Files ? 609
Lines ? 39249
Branches ? 7874
=======================================
Hits ? 22682
Misses ? 14741
Partials ? 1826 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@annajowang , It looks like all the stages passed. Could you please take a look at this? |
|
@annajowang , Hi, is there a problem? It looks like the merge hasn't gone through yet. |
|
There are limitations to what github checks can be run for contributors. |
Description
I added the endpoint and also added test code for the endpoint.
Additional Context
Actually, the latest version of the package has been released, but the existing method,
npm i @google-cloud/storage@latest, failed to download the package.@google-cloud/storage v7.20.0 release