Repository navigation
update to MIT licence - #187
Merged
Merged
Conversation
as requested in #186
Owner
|
Looks good, aside the test failing in PHP 5.2. Again I stop supporting this project so, if someone wants to fix that test will be happy to merge it |
Contributor
Author
|
Federico Ulfo dixit:
Looks good, aside the test failing in PHP 5.2.
That’s because the test runs in a *buntu trusty (14.04, waaaaay old)
environment, but PHP 5.2 is only available in precise (12.04, even
older and, by now, so long out of support it’s frozen and insecure).
(Yes, I actually looked.)
Thanks for acknowledging and merging! I’ll update the Debian package
once you’ll publish the next release (at least tag it).
|
Owner
|
Good point. I’ll tag this release.
…Sent from my iPhone
On Jun 8, 2018, at 5:59 PM, mirabilos ***@***.***> wrote:
Federico Ulfo dixit:
>Looks good, aside the test failing in PHP 5.2.
That’s because the test runs in a *buntu trusty (14.04, waaaaay old)
environment, but PHP 5.2 is only available in precise (12.04, even
older and, by now, so long out of support it’s frozen and insecure).
(Yes, I actually looked.)
Thanks for acknowledging and merging! I’ll update the Debian package
once you’ll publish the next release (at least tag it).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as requested in #186
Note to others: pending review by @feulf and merging into
masterto become binding