Share terminal payloads across constant buffer addresses - #391
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sbillig
added this pull request to stack #394
October 5, 2026 01:38
sbillig
force-pushed
the
perf/share-terminal-payload-addresses
branch
from
October 5, 2026 01:45
128c4fb to
d4c149d
Compare
sbillig
removed this pull request from stack #394
October 5, 2026 01:50
sbillig
changed the base branch from
perf/eliminate-empty-evm-memory-copies
to
main
October 5, 2026 01:50
sbillig
added this pull request to stack #395
October 5, 2026 01:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow terminal payload helpers to take a buffer base as a parameter when their store layouts differ only by a constant address translation. Include helpers produced by exact sharing in the later parameterized grouping.
Allocation placement can assign equivalent return or revert payloads different addresses, which previously prevented sharing. Comparing relative layouts exposes those duplicates while preserving each original address, store order, full-width arithmetic, and return or revert behavior. Profitability includes helper bodies and forwarding stubs.