Sitelet https://github.com/faker-ruby/faker/pull/2965
Skip to content

Add phone_number.country_code and address.full_address in locale sv - #2965

Merged
stefannibrasil merged 2 commits into
faker-ruby:mainfrom
larkro:update-locale-sv
Jun 11, 2024
Merged

stefannibrasil merged 2 commits into
faker-ruby:mainfrom
larkro:update-locale-sv

Conversation

@larkro

@larkro larkro commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Motivation / Background

I'm Swedish and noticed error when tested it to generate Swedish phone_number and addresses.
This Pull Request has been created to correct phone_number.country_code and address.full_address in locale sv.

Additional information

locale sv phone_number.country_code should be +46, reference https://countrycode.org/sweden

sv do not have #{state_abbr} as in default locale, the format is described here https://en.wikipedia.org/wiki/Postal_codes_in_Sweden#Format

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

@stefannibrasil stefannibrasil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @larkro ☎️

@stefannibrasil
stefannibrasil merged commit 717f6e0 into faker-ruby:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants