Upgrade to auto-value-gson 1.0.0: [ECR-3032] - #971
Merged
dmitry-timofeev merged 3 commits intoJun 26, 2019
Merged
Conversation
Also, remove redundant factories because a generated factory includes *all* accessible type adapters. As they are currently public, a single factory is sufficient per module.
dmitry-timofeev
requested review from
MakarovS and
bullet-tooth
and removed request for
bullet-tooth
June 24, 2019 16:00
MakarovS
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Also, remove redundant factories because a generated factory includes
all accessible type adapters. As they are currently public,
a single factory is sufficient per module.
Q: Shall we make the type-adapter factory methods in autovalue classes non-public so that they do not appear in their public API; and add per-package factories?
See: https://jira.bf.local/browse/ECR-3032
Definition of Done