Sitelet https://github.com/exonum/exonum-java-binding/pull/1385
Skip to content

Add ReadonlyFork [ECR-4164] - #1385

Closed
dmitry-timofeev wants to merge 2 commits into
add-prefixed-access-ECR-4159from
add-readonly-fork-ECR-4164
Closed

dmitry-timofeev wants to merge 2 commits into
add-prefixed-access-ECR-4159from
add-readonly-fork-ECR-4164

Conversation

@dmitry-timofeev

Copy link
Copy Markdown
Contributor

Overview


See:

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

@Disabled("ECR-xyz")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will "xyz" be resolved? 🙃

@AfterEach
void tearDown() throws CloseFailuresException {
try {
if (cleaner != null) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can it be null?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception in temporarydb

dmitry-timofeev added a commit that referenced this pull request Jan 29, 2020
dmitry-timofeev added a commit that referenced this pull request Jan 29, 2020
dmitry-timofeev added a commit that referenced this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants