Sitelet https://github.com/exonum/exonum-java-binding/pull/1005
Skip to content

Improve the path matching readability - #1005

Merged
dmitry-timofeev merged 1 commit into
exonum:masterfrom
dmitry-timofeev:improve-path-matching
Jul 12, 2019
Merged

Improve the path matching readability#1005
dmitry-timofeev merged 1 commit into
exonum:masterfrom
dmitry-timofeev:improve-path-matching

Conversation

@dmitry-timofeev

@dmitry-timofeev dmitry-timofeev commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Overview

See: #997

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls

coveralls commented Jul 12, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 85.672% when pulling 69a5357 on dmitry-timofeev:improve-path-matching into e378dfa on exonum:master.

@dmitry-timofeev
dmitry-timofeev merged commit 3660c25 into exonum:master Jul 12, 2019
@dmitry-timofeev
dmitry-timofeev deleted the improve-path-matching branch July 12, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bullet-tooth bullet-tooth bullet-tooth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitry-timofeev @coveralls @bullet-tooth