Conversation
not "requestsHash" as in geth
geoknee
commented
Jan 28, 2025
RPCHeaderRequestsHash to RPCHeader
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14022 +/- ##
===========================================
- Coverage 46.90% 42.63% -4.28%
===========================================
Files 974 809 -165
Lines 81670 72359 -9311
Branches 759 0 -759
===========================================
- Hits 38307 30847 -7460
+ Misses 40377 38794 -1583
+ Partials 2986 2718 -268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was fixed upstream ethereum/go-ethereum#30926
tynes
reviewed
Jan 28, 2025
tynes
approved these changes
Jan 28, 2025
protolambda
reviewed
Jan 28, 2025
protolambda
left a comment
Contributor
There was a problem hiding this comment.
Need the omitempty tag to not end up with a null json attribute when encoding.
Co-authored-by: protolambda <proto@protolambda.com>
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
* add RequestsHash to op-service RPCHeader type * sources.RPCHeader.RequestsHash needs "requestsHash" json struct tag not "requestsHash" as in geth * remove comment This was fixed upstream ethereum/go-ethereum#30926 * add comment * Update op-service/sources/types.go Co-authored-by: protolambda <proto@protolambda.com> --------- Co-authored-by: protolambda <proto@protolambda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13981