Git Stack: Port UI to Bootstrap 5. Style users views. 3/? by biow0lf · Pull Request #3169 · errbit/errbit

biow0lf · 2026-09-13T13:23:32Z

Changes

Add breadcrumbs to application.html.erb
Enable stylesheet_link_tag integrity
Style users views
Configure kaminari
Fix GitHub Action jobs names
Enable stylesheet integrity
Add breadcrumbs to users views

Screenshots

Users#index

Users#new

Users#show

Users#edit

Copilot

🟡 Changes recommended

The layout switch omits user-page controls, notices, and the Gravatar avatar.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Continues the Bootstrap 5 migration for user views with breadcrumbs, styled forms, Kaminari localization, and CI updates.

Changes:

Styles user CRUD views and adds breadcrumbs.
Configures Kaminari with localized translations.
Enables stylesheet integrity.
Renames GitHub Actions jobs and updates the view spec.

File summaries

File	Change
`spec/views/users/index.html.erb_spec.rb`	Updates users table assertion.
`config/locales/pt-BR.yml`	Adds localization entries.
`config/locales/kaminari.pt-BR.yml`	Adds Portuguese pagination translations.
`config/locales/kaminari.en.yml`	Adds English pagination translations.
`config/locales/en.yml`	Adds localization entries.
`config/initializers/kaminari.rb`	Configures pagination windows.
`app/views/users/show.html.erb`	Updates user details styling.
`app/views/users/new.html.erb`	Styles the new-user view.
`app/views/users/index.html.erb`	Adds breadcrumbs and Bootstrap styling.
`app/views/users/edit.html.erb`	Styles the edit-user view.
`app/views/users/_fields.html.erb`	Adds Bootstrap form controls.
`app/views/shared/_notice_fingerprinter.html.erb`	Applies formatting updates.
`app/views/shared/_link_google_account.html.erb`	Applies formatting updates.
`app/views/shared/_link_github_account.html.erb`	Applies formatting updates.
`app/views/layouts/application.html.erb`	Adds breadcrumbs and stylesheet integrity.
`app/controllers/users_controller.rb`	Removes the legacy layout override.
`.github/workflows/herb.yml`	Renames the workflow job.
`.github/workflows/brakeman.yml`	Renames the workflow job.

Review details

Files reviewed: 18/18 changed files
Comments generated: 2
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟡 Changes recommended

Moderate issues remain with user-page layout content, Bootstrap field classes, breadcrumb localization, and pagination accessibility.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (4)

app/controllers/users_controller.rb:3

Removing this layout declaration makes new, edit, show, and their redirects use application, but that layout currently comments out the title/action-bar/flash rendering (app/views/layouts/application.html.erb:40-53). Consequently the user pages lose the cancel/edit/delete/account links and the create/update/delete feedback. Keep the legacy layout for these actions until the Bootstrap layout renders those slots, or enable equivalent rendering there.

class UsersController < ApplicationController

app/views/users/_fields.html.erb:54

The existing toggleRequiredPasswordMarks JavaScript (app/assets/javascripts/errbit.js:109-125) sets each password input's parent class to either "required" or "" on page load and when GitHub login changes. With this new Bootstrap structure, that parent is the .col wrapper, so the class is overwritten and the password fields lose their Bootstrap column layout on every new/edit page. Update the script to toggle a dedicated class without replacing the wrapper classes, or isolate the legacy marker in a separate wrapper.

<div class="row">
  <div class="col">
    <%= f.label :password, t(".password"), class: "form-label" %>
    <%= f.password_field :password, autocomplete: "new-password", class: "form-control" %>

config/locales/kaminari.en.yml:7

These new values replace First, Last, Previous, and Next with bare symbols. The existing Kaminari partials put these translations directly in anchors without an aria-label or visually hidden text, so screen-reader users cannot identify the pagination controls. Keep accessible textual labels or add accessible names in the pagination partials.

      first: "&laquo;"
      last: "&raquo;"
      previous: "&lsaquo;"
      next: "&rsaquo;"

config/locales/kaminari.pt-BR.yml:7

These new values replace First, Last, Previous, and Next with bare symbols. The existing Kaminari partials put these translations directly in anchors without an aria-label or visually hidden text, so screen-reader users cannot identify the pagination controls. Keep accessible textual labels or add accessible names in the pagination partials.

      first: "&laquo;"
      last: "&raquo;"
      previous: "&lsaquo;"
      next: "&rsaquo;"

Files reviewed: 18/18 changed files
Comments generated: 4
Review effort level: Lite

+          <li class="breadcrumb-item"><%= link_to("Home", root_path) %></li>
+          <li class="breadcrumb-item"><%= link_to("Users", users_path) %></li>


+    <div class="col">
+      <nav aria-label="breadcrumb">
+        <ol class="breadcrumb">
+          <li class="breadcrumb-item"><%= link_to("Home", root_path) %></li>


+          <li class="breadcrumb-item"><%= link_to("Home", root_path) %></li>
+          <li class="breadcrumb-item"><%= link_to("Users", users_path) %></li>


+          <li class="breadcrumb-item"><%= link_to("Home", root_path) %></li>
+          <li class="breadcrumb-item"><%= link_to("Users", users_path) %></li>


biow0lf self-assigned this Sep 13, 2026

biow0lf added this pull request to stack #3168 September 13, 2026 13:23

biow0lf changed the title ~~Git Stack: Port UI to Bootstrap 5. 3/?~~ Git Stack: Port UI to Bootstrap 5. Style users#new. 3/? Sep 13, 2026

biow0lf changed the title ~~Git Stack: Port UI to Bootstrap 5. Style users#new. 3/?~~ Git Stack: Port UI to Bootstrap 5. Style users views. 3/? Sep 14, 2026

biow0lf marked this pull request as ready for review September 14, 2026 18:53

biow0lf requested review from mikelolasagasti and a lite review from Copilot September 14, 2026 18:53

Copilot started reviewing on behalf of biow0lf September 14, 2026 18:54 View session

Copilot AI reviewed Sep 14, 2026

View reviewed changes

Comment thread app/controllers/users_controller.rb

Comment thread app/views/layouts/application.html.erb

biow0lf requested a lite review from Copilot September 14, 2026 20:55

Copilot started reviewing on behalf of biow0lf September 14, 2026 20:55 View session

Copilot AI reviewed Sep 14, 2026

View reviewed changes

biow0lf added 17 commits September 14, 2026 23:24

Add breadcrumbs for users#index page

05d57bf

Enable stylesheet_link_tag integrity

51c7877

Cleanup

f6b19cb

Update

60f8733

Fix test

f7f6bc9

Style users#new

cc7c9e2

Usability: all time zones

0d6aed2

Style users#new

f5b42ab

Configure kaminari

2aa7c64

Configure kaminari

8fe9975

Update

e9be529

Fix GitHub job names

1565467

Un-style app/views/users/_fields.html.erb

a89de4f

Configure kaminari

20a5d31

Update en locale

2015933

Style users/_fields

23eb51c

Style users/_fields

b196f0a

biow0lf added 9 commits September 14, 2026 23:24

Style users/_fields

da1fd38

Add breadcrumb for users#show

7247129

Un-style users#show

964c98b

Add name to users#show

b9e0f46

Add breadcrumb for users#edit

20acca1

Update

3d03a0c

Style all pages

4b4e760

Style users#edit

6acba19

Update locales

5176ec0

biow0lf force-pushed the port-ui-to-bootstrap-5-part-3 branch from 746465b to 5176ec0 Compare September 14, 2026 21:24

Navigation Menu

Git Stack: Port UI to Bootstrap 5. Style users views. 3/? - #3169

Git Stack: Port UI to Bootstrap 5. Style users views. 3/?#3169
biow0lf wants to merge 26 commits into
port-ui-to-bootstrap-5-part-2from
port-ui-to-bootstrap-5-part-3

biow0lf commented Sep 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		<li class="breadcrumb-item"><%= link_to("Home", root_path) %></li>
		<li class="breadcrumb-item"><%= link_to("Users", users_path) %></li>

Conversation

biow0lf commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Screenshots

Users#index

Users#new

Users#show

Users#edit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (4)

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

biow0lf commented Sep 13, 2026 •

edited

Loading