Sitelet https://github.com/dubinc/dub/pull/4304
Skip to content

Matching the analytics icon - #4304

Open
marcusljf wants to merge 1 commit into
mainfrom
analytics-icon-update
Open

Matching the analytics icon#4304
marcusljf wants to merge 1 commit into
mainfrom
analytics-icon-update

Conversation

@marcusljf

@marcusljf marcusljf commented Aug 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Updated the view analytics button icon to match the navigation icon for both the workspace and the partner.

CleanShot 2026-08-10 at 15 15 08@2x CleanShot 2026-08-10 at 15 15 01@2x

Summary by CodeRabbit

  • Style
    • Updated analytics links and “View Analytics” buttons with a clearer, consistent icon across the dashboard.
    • Applied the updated icon in commissions, partner applications, and analytics views.

@vercel

vercel Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview Aug 10, 2026 10:23pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 691083f8-bce0-4959-b895-709f75e1e176

📥 Commits

Reviewing files that changed from the base of the PR and between 5619e30 and add27e0.

📒 Files selected for processing (3)
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
  • apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
  • apps/web/ui/analytics/toggle.tsx
📝 Walkthrough

Walkthrough

The pull request replaces the ChartLine icon with LinesY in three “View Analytics” controls across shared analytics and program pages.

Changes

Analytics icon replacement

Layer / File(s) Summary
Update analytics controls
apps/web/ui/analytics/toggle.tsx, apps/web/app/app.dub.co/.../program/commissions/commissions-table.tsx, apps/web/app/app.dub.co/.../program/partners/applications/page-client.tsx		 The three “View Analytics” controls now import and render LinesY instead of ChartLine.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • dubinc/dub#3717: Modifies the analytics toggle layout in the same shared component.
  • dubinc/dub#3848: Changes analytics navigation and “View Analytics” controls.

Suggested reviewers: steven-tey

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: matching the View Analytics icon with the navigation analytics icon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch analytics-icon-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marcusljf