Conversation
Without the full feature, `parse_str::<Expr>("a = b")` and similar
range forms returned a partial LHS and then a generic "unexpected
token" for the leftover operator. Emit the same "enable full" message
already used for other unsupported expression forms.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1971.
Without the
fullfeature, parsing an assignment or range asExpr(for example viaAttribute::parse_argsorparse_str) successfully parsed only the left-hand side, then failed with a genericunexpected tokenon the leftover=/... Other unsupported forms already reportunsupported expression; enable syn's features=["full"].This makes assign and range take that same path in the non-
fullparse_exprimplementation.Test plan
cargo test --lib --no-default-features --features 'derive parsing printing clone-impls proc-macro test' nofull_expr_tests--all-featuressuite.