docs: note parse_nested_meta must consume non-path args - #2083
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
Document that when a nested meta item is not a bare path (e.g. align(N)), the closure must parse the remainder on meta.input; returning Ok(()) without consuming trailing tokens yields an error. Fixes dtolnay#1426
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attribute::parse_nested_metareturns an error when the closure does not consume non-path nested meta (for example the(N)inalign(N)), even if the closure itself returnsOk(()). That requirement was easy to miss from the existing docs.This adds a short note above the
#[repr]example stating that for non-path nested meta the closure must parse the remainder onmeta.input, and pointing at the existingalign/packedarms as the pattern to follow.Related
Fixes #1426
Docs-only.