Repository navigation
[browser] Default Webcil V1 unless UseMonoRuntime is true - #135051
Merged
Merged
Conversation
_WasmWebcilVersion selected V1 only when RuntimeFlavor=CoreCLR, a property set by the runtime repo build but never by the shipped SDK. A customer CoreCLR app (UseMonoRuntime=false) therefore fell through to V0, and startup aborted with "unsupported Webcil wrapper version 0; expected 2". Default to V1 and select V0 only for Mono (UseMonoRuntime=true), matching how the rest of the WebAssembly SDK targets detect the runtime flavor. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
enabled auto-merge (squash)
October 1, 2026 21:58
maraf
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_WasmWebcilVersioninMicrosoft.NET.Sdk.WebAssembly.Browser.targetsselects Webcil V1 only whenRuntimeFlavor == 'CoreCLR'(added in #126876).RuntimeFlavoris set by the runtime repo build (WasmApp.InTree.props), but the shipped SDK and WebAssembly pack never set it. Everywhere else, these targets detect CoreCLR withUseMonoRuntime == 'false'.As a result, a customer CoreCLR browser app that sets only
UseMonoRuntime=falsefalls through to Webcil V0, and startup aborts:Evidence
Binlogs from the same app published with SDK
12.0.100-alpha.1.26480.103:ConvertDllsToWebcil.WebcilVersionSystem.Private.CoreLibWebcil headerUseMonoRuntime=false+RuntimeFlavor=CoreCLRUseMonoRuntime=falseonlyRuntimeFlavorFix
Default to V1, and select V0 only when
UseMonoRuntime == 'true'. The SDK defaults Mono browser apps toUseMonoRuntime=true, andWasmApp.InTree.propsmapsRuntimeFlavorontoUseMonoRuntimefor in-tree builds, so Mono output is unchanged.Validation
The patched targets were overlaid on the 26480.103 pack, and the app was republished with MSBuild node reuse disabled:
UseMonoRuntime=falseonly: V1 (previously V0)UseMonoRuntime=false+RuntimeFlavor=CoreCLR: V1UseMonoRuntime=true: V0Note
This pull request was generated by GitHub Copilot.