Repository navigation
Fix offline machine semaphore notification - #5330
Open
DrewScoggins wants to merge 1 commit into
Open
DrewScoggins wants to merge 1 commit into
DrewScoggins wants to merge 1 commit into
Conversation
Isolate the fallback Azure SDK environment from Helix PYTHONPATH and preserve Linux prerequisite failures after machine health checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a871b3ed-f5bd-4e33-8e77-69156ad981fb
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fixes correctly address both reported failure modes with regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes offline-machine notification reliability when Linux prerequisite setup fails.
Changes:
- Isolates the fallback virtual environment from Helix Python variables.
- Preserves prerequisite failure status after health checks.
- Adds regression coverage for both failures.
| File | Description |
|---|---|
scripts/machine_health.py |
Sanitizes the fallback venv environment. |
scripts/run_performance_job.py |
Restores failure exit status after health checks. |
scripts/tests/test_machine_health.py |
Tests Python environment isolation. |
scripts/tests/test_run_performance_job.py |
Tests prerequisite failure preservation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LoopedBard3
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PYTHONPATH/PYTHONHOMEBackground
During the August Viper pool incident, 10 machines detected an interrupted dpkg state and successfully created
/etc/helix-prep/offline, but all 10 failed to write theiroffline-machinessemaphore. The fallback virtual environment inherited Helix'sPYTHONPATH, causing/etc/helix/scripts/azureto shadow the Azure SDK packages installed into the venv. The resulting import failed withNo module named 'azure.storage.queue'.The Linux prerequisite command sequence also returned success after running the health check, masking the original setup failure.
Validation
py -3 -m pytest scripts/tests/test_machine_health.py scripts/tests/test_run_performance_job.py -q