Conversation
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
@dotnet/roslyn-infrastructure, please resolve the merge conflict. |
c19c6ec to
89f8575
Compare
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Caution 🚨 Action Required — Conflict detectedA conflict was detected when trying to update this PR with changes from build The conflicts in the following files need to be manually resolved:
ℹ️ To resolve the conflicts, please follow these steps:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/060158d3d6b4de649230a08a4d99bcb829e1caeb..9e0445ce8434308d803582875f326af60be9bdc8 From: dotnet/roslyn@060158d To: dotnet/roslyn@9e0445c [[ commit created by automation ]]
…9384-f68f6f843884
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@jjonescz, Roslyn flow remains red after its replacement run. Root causeRoslyn upstream collapsed the ...Handler.Diagnostics.Public namespace in commit range c370e64…9e0445c . That change has two halves:
The codeflow applied half 1 but only +4/−4 of half 2 — 19 deletions were dropped: the using …Handler.Diagnostics.Public; on line 12, and the two Public* factory classes on lines 34–51. Upstream's file is 33 lines with zero Public references; the PR head is 52 lines with seven. source-manifest.json was still advanced to 9e0445c , so the recorded SHA says "fully synced" while the tree isn't. Result: the consumer references types whose definitions were deleted in the same PR → CS0234 / CS0246 . It got into that state because Maestro could never complete an update. Five consecutive attempts (builds 334749, 334854, 334857, 334869, 334871) all conflicted and were never resolved, leaving the branch partially applied. The conflict is on one element in src/roslyn/src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj :
Both sides edited the same element, so every roslyn flow into that branch conflicts. Only release/11.0.2xx carries the override — main and release/11.0.1xx match upstream and flow cleanly. Recommended fix
git clone https://github.com/dotnet/dotnet && cd dotnet When resolving Microsoft.NET.ProjectData.Tasks.csproj , take the upstream side — drop the VMR-local block: netstandard2.0 $(NetRoslynSourceBuild) Safe for source-build: roslyn's eng/targets/TargetFrameworks.props sets both NetRoslyn and NetRoslynSourceBuild to $(NetCurrent) when DotNetBuildSourceOnly == true , so the override was already redundant there. Outside source-build the TFM changes from netstandard2.0 to $(NetRoslynAll) — roslyn's own decision, validated by their CI. Then confirm VSTypeScriptPullDiagnosticHandlerProvider.cs ends up at 33 lines with zero Public references, matching upstream. That's the check that the dropped 19 deletions actually landed.
|
Diff: https://github.com/dotnet/roslyn/compare/9e0445ce8434308d803582875f326af60be9bdc8..5b26970240a5891bb1808a30ad859422718efd48 From: dotnet/roslyn@9e0445c To: dotnet/roslyn@5b26970 [[ commit created by automation ]]
…9384-f68f6f843884
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/5b26970240a5891bb1808a30ad859422718efd48..e6f85a774c9bd0b8ad6fbc862202dede0bd6440f From: dotnet/roslyn@5b26970 To: dotnet/roslyn@e6f85a7 [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/e6f85a774c9bd0b8ad6fbc862202dede0bd6440f..d2c66271eb154ab7e31ed5349a88c4890f04f0c2 From: dotnet/roslyn@e6f85a7 To: dotnet/roslyn@d2c6627 [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/d2c66271eb154ab7e31ed5349a88c4890f04f0c2..dec3f6c5ae1531286ff184d5cbded5302c8d18cf From: dotnet/roslyn@d2c6627 To: dotnet/roslyn@dec3f6c [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/dec3f6c5ae1531286ff184d5cbded5302c8d18cf..d85604e8e91bf926fab836bc34f966333e290820 From: dotnet/roslyn@dec3f6c To: dotnet/roslyn@d85604e [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/d85604e8e91bf926fab836bc34f966333e290820..8d2c75f24c88ea99a01a8579ecb67e303d566670 From: dotnet/roslyn@d85604e To: dotnet/roslyn@8d2c75f [[ commit created by automation ]]
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/roslyn/compare/8d2c75f24c88ea99a01a8579ecb67e303d566670..bb79a699359d8a5d4e4889e989fdf7e69268fab4 From: dotnet/roslyn@8d2c75f To: dotnet/roslyn@bb79a69 [[ commit created by automation ]]
…9384-f68f6f843884
|
Note PRs from original repository included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/roslyn
Diff the source with this PR branch