Sitelet https://github.com/dotnet/dotnet/pull/9874
Skip to content

[release/11.0.2xx] Source code updates from dotnet/roslyn - #9874

Merged
jjonescz merged 15 commits into
release/11.0.2xxfrom
darc-release/11.0.2xx-1cb6e065-aa3f-4464-9384-f68f6f843884
Oct 5, 2026
Merged

jjonescz merged 15 commits into
release/11.0.2xxfrom
darc-release/11.0.2xx-1cb6e065-aa3f-4464-9384-f68f6f843884

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/roslyn

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/roslyn:bb79a699359d8a5d4e4889e989fdf7e69268fab4..https://github.com/dotnet/dotnet:darc-release/11.0.2xx-1cb6e065-aa3f-4464-9384-f68f6f843884

@dotnet-maestro

dotnet-maestro Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 334749 of https://github.com/dotnet/roslyn/tree/a1bbcb8c7337ff9c51e642bdb9564577a3d928b9.

The conflicts in the following files need to be manually resolved:

  • eng/Packages.props
    🔍 View file in dotnet/roslyn vs VMR
  • src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj
    🔍 View file in dotnet/roslyn vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository

    git clone https://github.com/dotnet/dotnet
    cd dotnet
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26451.2 or higher)

    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally

    darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251 

    This should apply the build 334749 with sources from a1bbcb8

  4. Resolve the conflicts, commit & push the changes

  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team October 1, 2026 13:59
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@JulieLeeMSFT

Copy link
Copy Markdown
Member

A conflict was detected when trying to update this PR with changes from build 334749 of https://github.com/dotnet/roslyn/tree/a1bbcb8c7337ff9c51e642bdb9564577a3d928b9.

@dotnet/roslyn-infrastructure, please resolve the merge conflict.

@dotnet-maestro
dotnet-maestro Bot force-pushed the darc-release/11.0.2xx-1cb6e065-aa3f-4464-9384-f68f6f843884 branch from c19c6ec to 89f8575 Compare October 2, 2026 03:14
@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 334854 of https://github.com/dotnet/roslyn/tree/e8459ca1936918536408770059b6530728849c7a.

The conflicts in the following files need to be manually resolved:

  • eng/Packages.props
    🔍 View file in dotnet/roslyn vs VMR
  • src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj
    🔍 View file in dotnet/roslyn vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository

    git clone https://github.com/dotnet/dotnet
    cd dotnet
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26451.2 or higher)

    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally

    darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251 

    This should apply the build 334854 with sources from e8459ca

  4. Resolve the conflicts, commit & push the changes

  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 334857 of https://github.com/dotnet/roslyn/tree/8ddc2f18d7a23028823d0870abf60e4b61cda24e.

The conflicts in the following files need to be manually resolved:

  • eng/Packages.props
    🔍 View file in dotnet/roslyn vs VMR
  • src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj
    🔍 View file in dotnet/roslyn vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository

    git clone https://github.com/dotnet/dotnet
    cd dotnet
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26451.2 or higher)

    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally

    darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251 

    This should apply the build 334857 with sources from 8ddc2f1

  4. Resolve the conflicts, commit & push the changes

  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 334869 of https://github.com/dotnet/roslyn/tree/370a9bd9a766dff58d407d75046c862f74bfdca6.

The conflicts in the following files need to be manually resolved:

  • eng/Packages.props
    🔍 View file in dotnet/roslyn vs VMR
  • src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj
    🔍 View file in dotnet/roslyn vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository

    git clone https://github.com/dotnet/dotnet
    cd dotnet
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26451.2 or higher)

    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally

    darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251 

    This should apply the build 334869 with sources from 370a9bd

  4. Resolve the conflicts, commit & push the changes

  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Caution

🚨 Action Required — Conflict detected

A conflict was detected when trying to update this PR with changes from build 334871 of https://github.com/dotnet/roslyn/tree/060158d3d6b4de649230a08a4d99bcb829e1caeb.

The conflicts in the following files need to be manually resolved:

  • eng/Packages.props
    🔍 View file in dotnet/roslyn vs VMR
  • src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj
    🔍 View file in dotnet/roslyn vs VMR

ℹ️ To resolve the conflicts, please follow these steps:

  1. Clone the current repository

    git clone https://github.com/dotnet/dotnet
    cd dotnet
  2. Make sure your darc is up-to-date
    (version 1.1.0-beta.26451.2 or higher)

    # Linux / MacOS
    ./eng/common/darc-init.sh
    # or on Windows
    .\eng\common\darc-init.ps1
  3. Run from repo's git clone and follow the instructions provided by the command to stage the conflict locally

    darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251 

    This should apply the build 334871 with sources from 060158d

  4. Resolve the conflicts, commit & push the changes

  5. Once pushed, the Codeflow verification check will turn green.
    If not, a new build might have flown into the PR and you might need to run the command above again.

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@JulieLeeMSFT

JulieLeeMSFT commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

@jjonescz, Roslyn flow remains red after its replacement run.

Root cause

Roslyn upstream collapsed the  ...Handler.Diagnostics.Public  namespace in commit range  c370e64…9e0445c . That change has two halves:

  1. delete  src/LanguageServer/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticHandlerFactory.cs  and  PublicWorkspacePullDiagnosticHandlerFactory.cs 
  2. strip the matching references out of  src/EditorFeatures/Core/ExternalAccess/VSTypeScript/VSTypeScriptPullDiagnosticHandlerProvider.cs  ( +4/−23  upstream)

The codeflow applied half 1 but only  +4/−4  of half 2 — 19 deletions were dropped: the  using …Handler.Diagnostics.Public;  on line 12, and the two  Public*  factory classes on lines 34–51. Upstream's file is 33 lines with zero  Public  references; the PR head is 52 lines with seven.  source-manifest.json  was still advanced to  9e0445c , so the recorded SHA says "fully synced" while the tree isn't.

Result: the consumer references types whose definitions were deleted in the same PR →  CS0234  /  CS0246 .

It got into that state because Maestro could never complete an update. Five consecutive attempts (builds 334749, 334854, 334857, 334869, 334871) all conflicted and were never resolved, leaving the branch partially applied.

The conflict is on one element in  src/roslyn/src/ProjectData/Microsoft.NET.ProjectData.Tasks/Microsoft.NET.ProjectData.Tasks.csproj :

  • VMR  release/11.0.2xx  added  $(NetRoslyn)  plus  EnableAotAnalyzer / EnableTrimAnalyzer  false
  • roslyn upstream rewrote the same    to  $(NetRoslynSourceBuild)  and deleted those analyzer lines

Both sides edited the same element, so every roslyn flow into that branch conflicts. Only  release/11.0.2xx  carries the override —  main  and  release/11.0.1xx  match upstream and flow cleanly.

Recommended fix

  1. Unblock the PR now — resolve the conflict and let the full roslyn diff land:

git clone https://github.com/dotnet/dotnet && cd dotnet
./eng/common/darc-init.ps1
darc vmr resolve-conflict --subscription 0ced2b69-f424-4e43-96ce-6a74693be251

When resolving  Microsoft.NET.ProjectData.Tasks.csproj , take the upstream side — drop the VMR-local block:

netstandard2.0
$(NetRoslyn)
false
false

$(NetRoslynSourceBuild)

Safe for source-build: roslyn's  eng/targets/TargetFrameworks.props  sets both  NetRoslyn  and  NetRoslynSourceBuild  to  $(NetCurrent)  when  DotNetBuildSourceOnly == true , so the override was already redundant there. Outside source-build the TFM changes from  netstandard2.0  to  $(NetRoslynAll)  — roslyn's own decision, validated by their CI.

Then confirm  VSTypeScriptPullDiagnosticHandlerProvider.cs  ends up at 33 lines with zero  Public  references, matching upstream. That's the check that the dropped 19 deletions actually landed.

  1. Prevent the recurrence — the local override is why every roslyn flow into  release/11.0.2xx  conflicts. Removing it in step 1 fixes this permanently. If some VMR-specific need still requires it, upstream it to dotnet/roslyn rather than re-patching the branch.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro

dotnet-maestro Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@jjonescz
jjonescz requested review from a team as code owners October 5, 2026 12:22
@jjonescz
jjonescz enabled auto-merge (squash) October 5, 2026 13:43
@jjonescz
jjonescz merged commit bc71044 into release/11.0.2xx Oct 5, 2026
15 of 16 checks passed
@jjonescz
jjonescz deleted the darc-release/11.0.2xx-1cb6e065-aa3f-4464-9384-f68f6f843884 branch October 5, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants