Feature | Implement SqlConnection.GetSchemaAsync - #3005
Merged
Merged
Conversation
roji
reviewed
Nov 14, 2024
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
- Coverage 66.02% 64.48% -1.55%
==========================================
Files 277 271 -6
Lines 42989 65791 +22802
==========================================
+ Hits 28383 42423 +14040
- Misses 14606 23368 +8762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edwardneal
marked this pull request as draft
November 15, 2024 22:38
This introduces async-over-sync, removing such requires work with the state machine and separate review.
edwardneal
marked this pull request as ready for review
November 16, 2024 08:56
Contributor
|
@edwardneal - Can you resolve the conflicts, and then I will kick off another CI run? |
Contributor
Author
|
Thanks @paulmedynski, I've just brought the branch up to date. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
requested changes
Jul 4, 2025
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
A few inconsistencies and questions.
Remove SqlDataReader.GetSchemaTableAsync (and references to such.) Expand test coverage of both GetSchema and GetSchemaAsync. Correct typo in documentation for GetSchema and GetSchemaAsync.
paulmedynski
previously approved these changes
Jul 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Oct 2, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #646, adding
SqlConnection.GetSchemaAsync.I can't add the IDbColumnSchemaGenerator method because the .NET Framework version of SqlDataReader doesn't yet implement that interface. #2967 tracks this.
SqlDataReader.GetSchemaTableAsyncrequires some extra work with the state machine to guarantee that the column metadata is available, and I'll submit a separate PR for this.I've added some basic documentation, but this effectively follows the
SqlCommand.[Something]Asyncpattern of "An asynchronous version of [Something], which <etc.>"I've also moved the netfx GetSchema methods from SqlConnectionHelper.cs to SqlConnection.cs, to align that part of it with netcore. This contributes to the merge slightly.