Added missing step causing compilation issue - #20000
Merged
Merged
Conversation
Fixed guide to remove compilation issue caused by incorrect namespace in greet.proto.
Contributor
Author
|
JunTaoLuo @guardrex Is there anything else you need me to do? from my perspective, it is completed |
Collaborator
|
We just need John to approve this and then we can get it merged. Stand-by for a bit longer ... the product unit 🐈 is very busy these days with the upcoming .NET 5 release, so there will be short delays for doc reviews during this period. 🏃🏃🏃🏃🏃😅 |
JunTaoLuo
approved these changes
Sep 28, 2020
JunTaoLuo
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. We updated our server templates to include adjusting the namespace but we never updated the docs for creating the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed guide to remove compilation issue caused by incorrect namespace in greet.proto.