Update sample readme for Create gRPC client & server - #18169
Conversation
|
@Rick-Anderson, I'm not sure how to get a review build and URI for this sample readme.md. |
|
You can add the readme content to one of your repos like I did here I don't see any value to the readme, I think you can delete it. All the info is in a tutorial, right? |
|
The only value the readme provides, is a way for the sample to be discoverable through the sample browser system. The readme is required by the sample system for that to happen. |
Rick-Anderson
left a comment
There was a problem hiding this comment.
Looks OK to me, assuming we want to keep this.
|
For now, I will update the readme so it at least points to the right tutorial until I can get it removed from the samples system. |
|
@Rick-Anderson, sorry, I forgot I didn't have patches to squash and squashed when merging. I will try to remember not to do that. |
|
Fixes #16467 |
For Internal Review: I am not sure how to get a review build for sample readme.md files which lacks structure used by the review build process.
Fixes #16467
Updated the readme.md to point to the sample tutorial rather than duplicate the tutorial in the readme itself which became quickly out of date.