Fix overflow in Actions Summary - #660
Open
whois-jon-peterson wants to merge 3 commits into
Open
whois-jon-peterson wants to merge 3 commits into
whois-jon-peterson wants to merge 3 commits into
Conversation
|
As per issue #654 , we have tested this fix and found the issue still occurs. We do have other actions which write content to the step summary, not sure if the truncation logic accounts for this? |
jozefizso
self-requested a review
December 4, 2025 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #589 a regression was introduced. A
shortSummaryvariable (holding a 35+ byte string) was created outside thegetReportfunction and prepended to the step summary, bypassing the Action's truncation logic. For summaries that need truncation, this causes them to still overflow in many cases.This PR
getReportto pass aprependStringprependStringLenas an input totrimReportThis may resolve issue #654, but needs further confirmation from the reporter.