Match Castle Siege scene effects, sound, and object creation - #140
Open
loserkidsblink wants to merge 4 commits into
Open
loserkidsblink wants to merge 4 commits into
loserkidsblink wants to merge 4 commits into
Conversation
Report for RSBE01_02 (f168bd9 - 41317d4)📈 Matched code: 1.22% (+0.03%, +4048 bytes) ✅ 4 new matches
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stEmblem::updateScene00,updateScene01,updateSE, andcreateObjfor RSBE01_02.createObj, with named fields in the alternate build, and separate the two ground loops' local pointers to reproduce the original instructions.Verification
ninja --quiet all_source build/RSBE01_02/ok build/RSBE01_02/report.jsonpasses.st_emblemrises from 3,656 to 7,704 bytes (+4,048); all four functions above reach 100%.This is based on current
main.