feat: breadth-first search algorithm - #102
Merged
Merged
Conversation
bal7hazar
approved these changes
Oct 8, 2024
bal7hazar
left a comment
Collaborator
There was a problem hiding this comment.
Nice job!
I took the liberty of making few modifications to simply the code such as:
- Switch from
looptowhileloops when possible - Remove the
Queuetype which was just an Array wrapper - Shuffle the directions when checking neighbors to avoid having hard coded patterns in game (like if the next move can either be North or West, we don't want it to be always North for instance but pseudo randomly one of those).
- Fixed a test where the grid was not the same as the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96
Introduced changes
Checklist