Sitelet https://github.com/documentcloud/docsplit/pull/119/commits/c67a0038b9dfc78730f726ef4ffc32e575ac6166
Skip to content

Fixes bug on empty result for command "#{office_executable} -h 2>#{null}... #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knowtheory merged 1 commit into from
Nov 17, 2014
Merged

Fixes bug on empty result for command "#{office_executable} -h 2>#{null}... #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes bug on empty result for command "#{office_executable} -h 2>#{nu… 
…ll}"

On Debian Jessie with LibreOffice 4.3.2, this line fails because the command returns nothing.
  • Loading branch information
@burisu
burisu committed Oct 17, 2014
commit c67a0038b9dfc78730f726ef4ffc32e575ac6166
2 changes: 1 addition & 1 deletion lib/docsplit/pdf_extractor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def version_string
unless @@version_string
null = windows? ? "NUL" : "/dev/null"
@@version_string = `#{office_executable} -h 2>#{null}`.split("\n").first
if !!@@version_string.match(/[0-9]*/)
if !!@@version_string.to_s.match(/[0-9]*/)
@@version_string = `#{office_executable} --version`.split("\n").first
end
end
Expand Down