Repository navigation
Validate SSHFP fingerprint lengths - #415
Merged
ibauersachs merged 3 commits intoSep 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
============================================
- Coverage 66.97% 66.96% -0.02%
- Complexity 3085 3096 +11
============================================
Files 198 198
Lines 13691 13702 +11
Branches 2140 2141 +1
============================================
+ Hits 9170 9175 +5
- Misses 3941 3948 +7
+ Partials 580 579 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks! I added some more tests and shared the digest lengths, as these are used in quite a few places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSHFP records such as
1 1 AABBCCDDcurrently accept a four-byte SHA-1 fingerprint. Validate the expected 20-byte SHA-1 and 32-byte SHA-256 lengths in the constructor and text parser, following the existing DSRecord behavior. Unknown digest types remain unrestricted.Fixes #414.
Added regression coverage for valid fingerprints, incorrect lengths, and unknown digest types. All 24 SSHFP tests pass; 18 cases fail without the fix.
Validation on Java 17:
mvn -Dtest=SSHFPRecordTest testpassed.mvn verify -Dgpg.skip -DexcludedGroups=concurrencyran 1,770 tests with oneResolverTest.resolverListenerExceptionUnwraptimeout failure, also reproduced on clean upstream.mvn verify -DskipTests -Dgpg.skippassed packaging, API compatibility, formatting, and Checkstyle checks.