fix: Upgrade dependencies with known CVEs - #1821
Open
javier-aliaga wants to merge 1 commit into
Open
javier-aliaga wants to merge 1 commit into
javier-aliaga wants to merge 1 commit into
Conversation
Jackson 2.21.7, Jackson 3 3.1.7, Netty 4.2.17.Final, Spring Boot 4.0.8, OpenTelemetry 1.62.0 and Tomcat 11.0.25. The OpenTelemetry and Jackson BOMs are imported before the Spring Boot BOM, including in the modules that import the Spring Boot 4 BOM locally, so they are not overridden. Signed-off-by: Javier Aliaga <javier@diagrid.io>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The published SDK BOM does not propagate the OpenTelemetry security constraint to consumers.
Review effort: Balanced
Findings: 1
What changed in this PR
Upgrades runtime dependencies to patched versions and adjusts BOM precedence to avoid vulnerable Spring Boot-managed versions.
Changes:
- Updates Jackson, Netty, Spring Boot, OpenTelemetry, and Tomcat.
- Prioritizes security-patched BOMs over Spring Boot dependency management.
- Aligns Spring Boot 4 modules with updated dependency versions.
| File | Description |
|---|---|
pom.xml |
Updates root dependency versions and BOM ordering. |
sdk-bom/pom.xml |
Updates exported Jackson and Netty constraints. |
sdk-tests/pom.xml |
Aligns test dependency management. |
spring-boot-sdk-tests/pom.xml |
Updates Spring Boot and security BOMs. |
spring-boot-examples/pom.xml |
Updates example dependency management. |
dapr-spring/dapr-spring-data/pom.xml |
Aligns Spring Data dependencies. |
dapr-spring/dapr-spring-boot-autoconfigure/pom.xml |
Updates autoconfiguration dependency constraints. |
dapr-spring/dapr-spring-boot-starters/dapr-spring-boot-starter/pom.xml |
Updates starter dependency management. |
dapr-spring/dapr-spring-boot-starters/dapr-spring-boot-starter-test/pom.xml |
Updates test starter dependency management. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <netty.version>4.2.16.Final</netty.version> | ||
| <jackson.version>2.21.2</jackson.version> | ||
| <netty.version>4.2.17.Final</netty.version> | ||
| <jackson.version>2.21.7</jackson.version> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1821 +/- ##
=========================================
Coverage 79.11% 79.11%
Complexity 2604 2604
=========================================
Files 264 264
Lines 7785 7785
Branches 820 820
=========================================
Hits 6159 6159
Misses 1266 1266
Partials 360 360 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clears every known vulnerability in the resolved runtime dependencies before cutting 1.19.0-rc-0. MvnRepository flags five jackson-databind CVEs on
dapr-sdk1.18.1 (CVE-2026-91777, -91776, -83557, -68497, -19032); master was on Jackson 2.21.2 and affected as well.jackson.version, root +sdk-bom)tools.jackson:jackson-bom)netty.version, root +sdk-bom)springboot.version,springboot4.version)opentelemetry.version)tomcat-embed-core, examples only)The OpenTelemetry and Jackson 3 BOMs now come before
spring-boot-dependenciesin the root pom; before, Spring Boot's managed versions won. The modules that import the Spring Boot 4 BOM locally (dapr-spring-boot-autoconfigure,-starter,-starter-test,dapr-spring-data,sdk-tests,spring-boot-examples,spring-boot-sdk-tests) also import the Jackson 2 and OpenTelemetry BOMs before it, for the same reason.Verified with an OSV scan of
mvn dependency:list(runtime scope) across all 38 modules including theintegration-testsprofile: 20 vulnerable artifacts before, 0 after.Issue reference
N/A (pre-release CVE sweep).
Checklist