[+] add TLS encryption to RPC channel - #796
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 15727504734Details
馃挍 - Coveralls |
Collaborator
|
Thanks for the PR. I don't want to add additional option. I want all needed options for sinks to be present in the connection url. For example, if one wants to use root CA with Postgres connection, they will just use sslrootcert option in connection string, e.g. I want to use the same approach for all sinks, so we don't bloat cmd options. This situation will hit us hard if one want to use two or more sinks but with different option values. |
pashagolub
reviewed
Jun 12, 2025
pashagolub
reviewed
Jun 12, 2025
pashagolub
reviewed
Jun 12, 2025
pashagolub
approved these changes
Jun 18, 2025
pashagolub
approved these changes
Jun 18, 2025
add new `root-ca $PW_RPC_ROOT_CA` flag for CA file path. use `tls` package to listen for connection and add user provided CA as a trusted authority. add rpc_tests_sinks dir containing test-only certificates to use in rpc_test.go
Collaborator
|
Thanks a lot! Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new
root-ca $PW_RPC_ROOT_CAflag for CA file path.use
tlspackage to listen for connection and add user provided CA as a trusted authority.add rpc_tests_sinks dir containing test-only certificates to use in rpc_test.go