Conversation
aslakhellesoy
requested changes
Apr 21, 2020
aslakhellesoy
left a comment
Contributor
There was a problem hiding this comment.
Some feedback to make the code more idiomatic
| public int y; | ||
|
|
||
| public PersonLocation(String person_, int x_, int y_) { | ||
| person = person_; |
Contributor
There was a problem hiding this comment.
More idiomatic: this.person = person - don't use underscores.
| package shouty; | ||
|
|
||
| public class PersonLocation { | ||
| public String person; |
Contributor
There was a problem hiding this comment.
Be a good citizen - declare all immutable fields as final
| import io.cucumber.java.Before; | ||
| import io.cucumber.java.Scenario; | ||
|
|
||
| import java.io.Console; |
added 2 commits
April 22, 2020 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for the Connect 2020 session with Emmanuel