Adds Notary Data Size/Delay Options - #378
Merged
Merged
Conversation
* Allow the caller to set the max sent and recv data themselves without a second fetch from the extension * Allow the caller to specify an arbitrary delay between response calculation and notary proof start Ref CSF-1191
GODrums
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref CSF-1191
Note
Medium Risk
Touches the TLSNotary prove flow by changing how
max_sent_data/max_recv_dataare determined and optionally inserting a delay, which can affect proof reliability and performance if misconfigured.Overview
Adds new optional
NotaryProveRequest.metaknobs to override transcript size limits (max_sent_data,max_recv_data) and to delay starting the prove step after response-size calculation (after_response_calc_delay_ms).Updates the offscreen notary prove handler to use caller-provided max sizes when present (skipping the extra response-size fetch) and to
wait()for the configured delay after computingmaxRecvData, to help avoid rate limiting.Written by Cursor Bugbot for commit 58d60fd. This will update automatically on new commits. Configure here.